Add jfpc cache staleness alert to config and pass it into jfpc cache #12595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
reviewed
Apr 1, 2024
jmank88
previously approved these changes
Apr 1, 2024
…stable-staleness-alert # Conflicts: # core/services/ocr2/plugins/median/services.go # core/services/ocrcommon/data_source.go # core/services/ocrcommon/data_source_test.go
jmank88
previously approved these changes
Apr 4, 2024
…stable-staleness-alert # Conflicts: # core/internal/features/ocr2/features_ocr2_test.go
|
jmank88
approved these changes
Apr 10, 2024
This was referenced Apr 12, 2024
ilija42
added a commit
that referenced
this pull request
Apr 22, 2024
…12595) * Add jfpc cache staleness alert to config and pass it into jfpc cache * Extract JuelsPerFeeCoinCache cfg into a separate struct, improve naming * Changeset * Update config validation test * Reduce changeset to minor
This was referenced Apr 24, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 1, 2024
* Bump version and update CHANGELOG for core 2.11.0 Signed-off-by: Sneha Agnihotri <sneha.agnihotri@smartcontract.com> * Add jfpc cache staleness alert to config and pass it into jfpc cache (#12595) * Add jfpc cache staleness alert to config and pass it into jfpc cache * Extract JuelsPerFeeCoinCache cfg into a separate struct, improve naming * Changeset * Update config validation test * Reduce changeset to minor * [BCF-3178] - Improve err handling and logs for in memory data source cache (#12907) * Fix inMemoryDataSourceCache get() warn log formatting * Fix in mem ds cache updateCache() to save runs even if some ds failed * Improve in memory data source cache Observe() logs and error messages * Add changeset * Bumping solana validator (#12832) * Bumping solana * Bumping the checksum for solana validator * Update release changelog with cherry pick commits from develop Signed-off-by: Sneha Agnihotri <sneha.agnihotri@smartcontract.com> * Cherry pick: enable jpfc cache by default (#12973) * Draft * Check JuelsPerFeeCoinCache before checking Disable param * Add test * Update NewInMemoryDataSourceCache * Update NewInMemoryDataSourceCache * Update release changelog with cherry pick commits from develop Signed-off-by: Sneha Agnihotri <sneha.agnihotri@smartcontract.com> * Remove duplicates Signed-off-by: Sneha Agnihotri <sneha.agnihotri@smartcontract.com> * Finalize date on changelog for 2.11.0 Signed-off-by: Sneha Agnihotri <sneha.agnihotri@smartcontract.com> * Remove codecov (#13020) (cherry picked from commit 2e99468) --------- Signed-off-by: Sneha Agnihotri <sneha.agnihotri@smartcontract.com> Co-authored-by: ilija42 <57732589+ilija42@users.noreply.github.com> Co-authored-by: Damjan Smickovski <32773226+smickovskid@users.noreply.github.com> Co-authored-by: george-dorin <120329946+george-dorin@users.noreply.github.com> Co-authored-by: HenryNguyen5 <6404866+HenryNguyen5@users.noreply.github.com>
davidcauchi
pushed a commit
that referenced
this pull request
May 6, 2024
* Bump version and update CHANGELOG for core 2.11.0 Signed-off-by: Sneha Agnihotri <sneha.agnihotri@smartcontract.com> * Add jfpc cache staleness alert to config and pass it into jfpc cache (#12595) * Add jfpc cache staleness alert to config and pass it into jfpc cache * Extract JuelsPerFeeCoinCache cfg into a separate struct, improve naming * Changeset * Update config validation test * Reduce changeset to minor * [BCF-3178] - Improve err handling and logs for in memory data source cache (#12907) * Fix inMemoryDataSourceCache get() warn log formatting * Fix in mem ds cache updateCache() to save runs even if some ds failed * Improve in memory data source cache Observe() logs and error messages * Add changeset * Bumping solana validator (#12832) * Bumping solana * Bumping the checksum for solana validator * Update release changelog with cherry pick commits from develop Signed-off-by: Sneha Agnihotri <sneha.agnihotri@smartcontract.com> * Cherry pick: enable jpfc cache by default (#12973) * Draft * Check JuelsPerFeeCoinCache before checking Disable param * Add test * Update NewInMemoryDataSourceCache * Update NewInMemoryDataSourceCache * Update release changelog with cherry pick commits from develop Signed-off-by: Sneha Agnihotri <sneha.agnihotri@smartcontract.com> * Remove duplicates Signed-off-by: Sneha Agnihotri <sneha.agnihotri@smartcontract.com> * Finalize date on changelog for 2.11.0 Signed-off-by: Sneha Agnihotri <sneha.agnihotri@smartcontract.com> * Remove codecov (#13020) (cherry picked from commit 2e99468) --------- Signed-off-by: Sneha Agnihotri <sneha.agnihotri@smartcontract.com> Co-authored-by: ilija42 <57732589+ilija42@users.noreply.github.com> Co-authored-by: Damjan Smickovski <32773226+smickovskid@users.noreply.github.com> Co-authored-by: george-dorin <120329946+george-dorin@users.noreply.github.com> Co-authored-by: HenryNguyen5 <6404866+HenryNguyen5@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add stalenessAlertThreshold to cfg and cosmetic improvements