Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On strict, Panic for stacktrace, otherwise Error, in EthMock#Call #1271

Merged
merged 1 commit into from
May 28, 2019
Merged

On strict, Panic for stacktrace, otherwise Error, in EthMock#Call #1271

merged 1 commit into from
May 28, 2019

Conversation

j16r
Copy link
Contributor

@j16r j16r commented May 28, 2019

This is a small change to improve the UX of the EthMock when Calls fail.

@j16r j16r merged commit 97215b6 into master May 28, 2019
@j16r j16r deleted the chore/improve_ethmock_feedback branch May 28, 2019 15:48
asoliman92 added a commit that referenced this pull request Aug 28, 2024
@winder @asoliman92
Updates to manual-execution program and batch runner script (#1271)
4d14ad6 
## Motivation

There were many transactions which needed to be executed.

## Solution

Finish the work that @dimkouv started in #631

---------

Co-authored-by: Abdelrahman Soliman (Boda) <2677789+asoliman92@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimroc dimroc dimroc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j16r @dimroc