Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ON DELETE CASCADE to workflow tables #13165

Merged
merged 1 commit into from
May 23, 2024
Merged

Add ON DELETE CASCADE to workflow tables #13165

merged 1 commit into from
May 23, 2024

Conversation

cedric-cordenier
Copy link
Contributor

No description provided.

@cedric-cordenier cedric-cordenier requested a review from a team as a code owner May 9, 2024 17:25
@cedric-cordenier cedric-cordenier enabled auto-merge May 9, 2024 17:27
krehermann
krehermann reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@krehermann krehermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a pnpm changeset with #db_update For any feature that introduces updates to database schema.

bolekk
bolekk reviewed May 22, 2024
View reviewed changes
core/store/migrate/migrations/00237_add_workflow_executions_on_delete.sql Outdated
@@ -0,0 +1,31 @@
-- +goose Up
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong file name (too many zeros)

@bolekk bolekk force-pushed the add-on-delete-cascade branch from 95bdb7f to 866446a Compare May 22, 2024 22:58
bolekk
bolekk previously approved these changes May 22, 2024
View reviewed changes
@bolekk bolekk disabled auto-merge May 23, 2024 00:57
@bolekk bolekk force-pushed the add-on-delete-cascade branch from 866446a to 42cbe9b Compare May 23, 2024 01:07
bolekk
bolekk previously approved these changes May 23, 2024
View reviewed changes
krehermann
krehermann previously approved these changes May 23, 2024
View reviewed changes
@bolekk bolekk dismissed stale reviews from krehermann and themself via 894fb33 May 23, 2024 01:18
@bolekk bolekk force-pushed the add-on-delete-cascade branch from 42cbe9b to 894fb33 Compare May 23, 2024 01:18
@krehermann krehermann enabled auto-merge May 23, 2024 01:24
@krehermann krehermann added this pull request to the merge queue May 23, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
2 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

Merged via the queue into develop with commit 1437410 May 23, 2024
107 checks passed
@krehermann krehermann deleted the add-on-delete-cascade branch May 23, 2024 01:52
@github-actions github-actions bot mentioned this pull request May 23, 2024
Draft
This was referenced May 23, 2024
Draft
Draft
cedric-cordenier added a commit that referenced this pull request May 29, 2024
@cedric-cordenier
Add ON DELETE CASCADE to workflow tables (#13165)
de3c1e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolekk bolekk bolekk approved these changes

@krehermann krehermann krehermann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cedric-cordenier @bolekk @krehermann