Make sure Tx is being updated with latest TxAttempt details #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimroc
approved these changes
Jun 6, 2019
j16r
deleted the
chore/be_extra_secure_in_the_knowledge_that_tx_attempt_saves_the_hash_to_the_tx
branch
asoliman92
pushed a commit
that referenced
this pull request
Aug 28, 2024
## Motivation Want to be maximally defensive for the address book to prevent corruption. ## Solution - Type contract and version - Let products compose type and version at deploy/state gen time to avoid a combinatorial number of strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to make extra sure this was working, because the behavior in FindTxByAttempt made me unsure ;)