-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump js-yaml from 3.13.0 to 3.13.1 in /explorer/client #1335
Merged
se3000
merged 1 commit into
master
from
dependabot/npm_and_yarn/explorer/client/js-yaml-3.13.1
Jun 9, 2019
Merged
Bump js-yaml from 3.13.0 to 3.13.1 in /explorer/client #1335
se3000
merged 1 commit into
master
from
dependabot/npm_and_yarn/explorer/client/js-yaml-3.13.1
Jun 9, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.13.0 to 3.13.1. - [Release notes](https://github.com/nodeca/js-yaml/releases) - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.13.0...3.13.1) Signed-off-by: dependabot[bot] <support@github.com>
se3000
approved these changes
Jun 9, 2019
dependabot
bot
deleted the
dependabot/npm_and_yarn/explorer/client/js-yaml-3.13.1
branch
June 9, 2019 18:58
asoliman92
pushed a commit
that referenced
this pull request
Aug 30, 2024
The key objective of allowlisting senders is to restrict the senders (EOA or smart contract) that can send CCIP Messages from a given blockchain to a specified destination blockchain. While acknowledging this additional check may come with gas cost, we aim to achieve this objective with minimal gas cost increments. The CCIP OnRamp contract must be able to allow only specific senders (EOA or smart contract), identified by address, to send CCIP messages to a specific destination blockchain, identified by destinationChainSelector. CCIP messages for a specific destination blockchain for which the sender is not included in the allowlist must be rejected. A proper error must be returned. It should be possible to activate/deactivate the allowlist capability of an OnRamp for a given destination chain. Options include: - A flag that enables/disables allowlisting capability - The selected approach should consider gas cost, clarity and simplicity. Only a designed entity must be able to update the allowlist configuration. By default this is CCIP Owner, but it must be possible for CCIP Owner to also add a third party (i.e. AllowListAdmin) to have this privilege. - Add new properties to DestChainConfig Struct ```js /// @dev Struct to hold the configs for a destination chain /// @dev sequenceNumber, allowListEnabled, router will all be packed in 1 slot struct DestChainConfig { // The last used sequence number. This is zero in the case where no messages have yet been sent. // 0 is not a valid sequence number for any real transaction. uint64 sequenceNumber; // boolean indicator to specify if allowList check is enabled bool allowListEnabled; // This is the local router address that is allowed to send messages to the destination chain. // This is NOT the receiving router address on the destination chain. IRouter router; // This is the list of addresses allowed to send messages from onRamp EnumerableSet.AddressSet allowedSendersList; } ``` - functions to applyAllowList ```js function applyAllowListUpdates(AllowListConfigArgs[] calldata allowListConfigArgsItems) external { ``` - a struct to hold the applyAllowList Information ```js struct AllowListConfigArgs { uint64 destChainSelector; // Destination chain selector bool allowListEnabled; // indicator to check if the allowedSendersList is enabled address[] addedAllowlistedSenders; // list of senders to be added to the allowedSendersList address[] removedAllowlistedSenders; // list of senders to be removed from the allowedSendersList } ``` --------- Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com>
asoliman92
pushed a commit
that referenced
this pull request
Aug 30, 2024
## Motivation The key objective of allowlisting senders is to restrict the senders (EOA or smart contract) that can send CCIP Messages from a given blockchain to a specified destination blockchain. While acknowledging this additional check may come with gas cost, we aim to achieve this objective with minimal gas cost increments. ### Requirements The CCIP OnRamp contract must be able to allow only specific senders (EOA or smart contract), identified by address, to send CCIP messages to a specific destination blockchain, identified by destinationChainSelector. CCIP messages for a specific destination blockchain for which the sender is not included in the allowlist must be rejected. A proper error must be returned. It should be possible to activate/deactivate the allowlist capability of an OnRamp for a given destination chain. Options include: - A flag that enables/disables allowlisting capability - The selected approach should consider gas cost, clarity and simplicity. Only a designed entity must be able to update the allowlist configuration. By default this is CCIP Owner, but it must be possible for CCIP Owner to also add a third party (i.e. AllowListAdmin) to have this privilege. ## Solution - Add new properties to DestChainConfig Struct ```js /// @dev Struct to hold the configs for a destination chain /// @dev sequenceNumber, allowListEnabled, router will all be packed in 1 slot struct DestChainConfig { // The last used sequence number. This is zero in the case where no messages have yet been sent. // 0 is not a valid sequence number for any real transaction. uint64 sequenceNumber; // boolean indicator to specify if allowList check is enabled bool allowListEnabled; // This is the local router address that is allowed to send messages to the destination chain. // This is NOT the receiving router address on the destination chain. IRouter router; // This is the list of addresses allowed to send messages from onRamp EnumerableSet.AddressSet allowedSendersList; } ``` - functions to applyAllowList ```js function applyAllowListUpdates(AllowListConfigArgs[] calldata allowListConfigArgsItems) external { ``` - a struct to hold the applyAllowList Information ```js struct AllowListConfigArgs { uint64 destChainSelector; // Destination chain selector bool allowListEnabled; // indicator to check if the allowedSendersList is enabled address[] addedAllowlistedSenders; // list of senders to be added to the allowedSendersList address[] removedAllowlistedSenders; // list of senders to be removed from the allowedSendersList } ``` --------- Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com>
RensR
pushed a commit
that referenced
this pull request
Oct 1, 2024
The key objective of allowlisting senders is to restrict the senders (EOA or smart contract) that can send CCIP Messages from a given blockchain to a specified destination blockchain. While acknowledging this additional check may come with gas cost, we aim to achieve this objective with minimal gas cost increments. The CCIP OnRamp contract must be able to allow only specific senders (EOA or smart contract), identified by address, to send CCIP messages to a specific destination blockchain, identified by destinationChainSelector. CCIP messages for a specific destination blockchain for which the sender is not included in the allowlist must be rejected. A proper error must be returned. It should be possible to activate/deactivate the allowlist capability of an OnRamp for a given destination chain. Options include: - A flag that enables/disables allowlisting capability - The selected approach should consider gas cost, clarity and simplicity. Only a designed entity must be able to update the allowlist configuration. By default this is CCIP Owner, but it must be possible for CCIP Owner to also add a third party (i.e. AllowListAdmin) to have this privilege. - Add new properties to DestChainConfig Struct ```js /// @dev Struct to hold the configs for a destination chain /// @dev sequenceNumber, allowListEnabled, router will all be packed in 1 slot struct DestChainConfig { // The last used sequence number. This is zero in the case where no messages have yet been sent. // 0 is not a valid sequence number for any real transaction. uint64 sequenceNumber; // boolean indicator to specify if allowList check is enabled bool allowListEnabled; // This is the local router address that is allowed to send messages to the destination chain. // This is NOT the receiving router address on the destination chain. IRouter router; // This is the list of addresses allowed to send messages from onRamp EnumerableSet.AddressSet allowedSendersList; } ``` - functions to applyAllowList ```js function applyAllowListUpdates(AllowListConfigArgs[] calldata allowListConfigArgsItems) external { ``` - a struct to hold the applyAllowList Information ```js struct AllowListConfigArgs { uint64 destChainSelector; // Destination chain selector bool allowListEnabled; // indicator to check if the allowedSendersList is enabled address[] addedAllowlistedSenders; // list of senders to be added to the allowedSendersList address[] removedAllowlistedSenders; // list of senders to be removed from the allowedSendersList } ``` --------- Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps js-yaml from 3.13.0 to 3.13.1.
Changelog
Sourced from js-yaml's changelog.
Commits
665aadd
3.13.1 releasedda8ecf2
Browser files rebuildb2f9e88
Merge pull request #480 from nodeca/toStringe18afbf
Fix possible code execution in (already unsafe) load()Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot ignore this [patch|minor|major] version
will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language