Syncer #13427
Merged
Syncer #13427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to |
makramkd
reviewed
Jun 5, 2024
cedric-cordenier
force-pushed
the
syncer
branch
2 times, most recently
from
5c7591a to
c28465b
Compare
bolekk
reviewed
Jun 7, 2024
cedric-cordenier
commented
Jun 7, 2024
DeividasK
previously approved these changes
Jun 13, 2024
bolekk
previously approved these changes
Jun 13, 2024
| } | ||
| } | ||
|
|
||
| func (s *registrySyncer) Start(ctx context.Context) error { | ||
| // NOTE: Decrease wg.Add and uncomment line 124 below |
There was a problem hiding this comment.
nit: line numbers change all the time
bolekk
approved these changes
Jun 13, 2024
DeividasK
approved these changes
Jun 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.