KS-318 move name, owner to yaml spec #13522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeividasK
reviewed
Jun 12, 2024
DeividasK
reviewed
Jun 12, 2024
DeividasK
reviewed
Jun 12, 2024
DeividasK
previously approved these changes
Jun 12, 2024
| // note: i tried to make these private, but translating them to the database seems to require them to be public | ||
| WorkflowID string `toml:"-" db:"workflow_id"` // Derived. Do not modify. the CID of the workflow. | ||
| WorkflowOwner string `toml:"-" db:"workflow_owner"` // Derived. Do not modify. the owner of the workflow. | ||
| WorkflowName string `toml:"-" db:"workflow_name"` // Derived. Do not modify. the name of the workflow. |
There was a problem hiding this comment.
🤔 Are we removing the Owner + Name from the database / job spec? Does any functionality rely on the WorkflowOwner / WorkflowName being exposed at the DB level? (I'm thinking of CLO)
There was a problem hiding this comment.
yes, i'll have to update the RDD.
yes, they will need to change some of there parsing.
they are using the pkgworfklows.ParseWorkflowSpecYaml today. they will be able to get these fields from the result of that, if they need them internally for their own private db purposes.
so instead of reading them from RDD (and forcing duplicated values between top-level RDD fields and embedded YAML tags), they can call a func they are already using and get the values
krehermann
force-pushed
the
ks-318/wf-name-owner-yaml
branch
from
ba5944e to
f09dcd5
Compare
krehermann
force-pushed
the
ks-318/wf-name-owner-yaml
branch
from
f09dcd5 to
c714b3a
Compare
bolekk
reviewed
Jun 13, 2024
krehermann
force-pushed
the
ks-318/wf-name-owner-yaml
branch
from
244bc37 to
2168c40
Compare
krehermann
force-pushed
the
ks-318/wf-name-owner-yaml
branch
from
2168c40 to
ef00d44
Compare
bolekk
approved these changes
Jun 13, 2024
HenryNguyen5
approved these changes
Jun 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/KS-318
Requires:
In conjunction with:
The key change is that Job Spec TOML now only needs the embedded WF YAML spec. The name, owner, and content hash are derived and do not need to be duplicated.
After this is merged, we will need to update the job specs to move the name and owner into the YAML and remove WorkflowID, WorkflowName, and WorkflowOwner from the job spec TOML