Bcf 3281 ability to deploy node using docker compose #13721

Atrax1 · 2024-06-28T14:12:22Z

Requires Dependencies

Resolves Dependencies

github-actions · 2024-07-02T10:31:32Z

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

#added For any new functionality added.
#breaking_change For any functionality that requires manual action for the node to boot.
#bugfix For bug fixes.
#changed For any change to the existing functionality.
#db_update For any feature that introduces updates to database schema.
#deprecation_notice For any upcoming deprecation functionality.
#internal For changesets that need to be excluded from the final changelog.
#nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
#removed For any functionality/config that is removed.
#updated For any functionality that is updated.
#wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

pavel-raykov · 2024-07-02T15:39:28Z

tools/docker/compose

-
-    cld                   Runs the chainlink node container in dev mode
-
-    acceptance            Run the services required to perform an acceptance test


why did you decide to remove this functionality?

I haven't its just renaming as it was just a docker compose up behind and not running any acceptance test

I see, that was a bad naming then.

Could you please update the README file accordingly then?

Yes I'll be pushing soon the updates on the README, PR is still in draft

pavel-raykov · 2024-07-03T12:08:25Z

tools/docker/docker-compose.yaml

@@ -32,8 +30,6 @@ services:
      dockerfile: core/chainlink.Dockerfile
    entrypoint: /bin/sh -c "chainlink -c /run/secrets/config node start -d -p /run/secrets/node_password -a /run/secrets/apicredentials"
    restart: always
-    environment:


Sorry, could you confirm that there is no application that runs "docker-compose -f docker-compose.yaml ..." which assumes that CL_DATABASE_URL is propagated somehow from the upstream?

you mean if used without the compose script and hence without docker-compose.postgres.yaml ?

Its not meant to be used without compose script

pavel-raykov · 2024-07-04T15:30:01Z

tools/docker/README.md

-The `cld` command will bring up the services that a chainlink node needs to connect to (parity/geth, postgres), and then attach the users terminal to a docker container containing the host's chainlink repository bind-mounted inside the container at `/usr/local/src/chainlink`. What this means is that any changes made within the host's repository will be synchronized to the container, and vice versa for changes made within the container at `/usr/local/src/chainlink`.
-
-This enables a user to make quick changes on either the container or the host, run `cldev` within the attached container, check the new behaviour of the re-built node, and repeat this process until the desired results are achieved.
+Will run one node with a postgres database and optionally by default a devnet RPC node that can be either geth or parity.


does this "optionally" make sense? (I.e., it just runs one node with postgres db and a devnet RPC [parity by default]).

similar for "./compose up"

sure will commit the changes soon 👍

pavel-raykov · 2024-07-04T15:41:59Z

tools/docker/README.md


 # Requirements

 - [docker-compose](https://docs.docker.com/compose/install/)

 # Using the compose script

-Inside the `chainlink/tools/docker` directory, there is a helper script that is included which should cover all cases of integration / acceptance / development needs acroos multiple services. To see a list of available commands, perform the following:
+Inside the `chainlink/tools/docker` directory, there is a helper script that is included


is this still a part of the sentence?

I'm updating the sentence to be more clear

pavel-raykov · 2024-07-04T15:55:09Z

tools/docker/README.md


 ```sh
 cd tools/docker
 ./compose help
 ```

-## Examples
+## Env vars


Could you please also explain what ".env" file does in this section?

pavel-raykov · 2024-07-05T07:52:30Z

tools/docker/README.md


 # Requirements

 - [docker-compose](https://docs.docker.com/compose/install/)

 # Using the compose script

-Inside the `chainlink/tools/docker` directory, there is a helper script that is included which should cover all cases of integration / acceptance / development needs acroos multiple services. To see a list of available commands, perform the following:
+You should use the script `compose` located in the `chainlink/tools/docker` directory


Add a dot to separate two sentences?

cl-sonarqube-production · 2024-07-05T09:19:31Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Atrax1 added 2 commits June 28, 2024 16:08

feat(docker): upgrade to new docker compose version

1321207

fix(docker): update name to avoid duplicate with core node

37dfbe3

Atrax1 self-assigned this Jun 28, 2024

Atrax1 temporarily deployed to sdlc June 28, 2024 14:12 — with GitHub Actions Inactive

feat(docker): remove unused env vars

a1298a6

Atrax1 temporarily deployed to sdlc July 2, 2024 10:30 — with GitHub Actions Inactive

feat(docker): enable dev mode with rebuild + cleanup

abca137

Atrax1 force-pushed the BCF-3281-ability-to-deploy-node-using-docker-compose branch from 9cd3490 to abca137 Compare July 2, 2024 10:31

Atrax1 temporarily deployed to sdlc July 2, 2024 10:31 — with GitHub Actions Inactive

jmank88 requested review from jmank88 and pavel-raykov July 2, 2024 14:38

pavel-raykov reviewed Jul 2, 2024

View reviewed changes

pavel-raykov reviewed Jul 3, 2024

View reviewed changes

feat(docker): cleanup and update README

3b441ca

Atrax1 temporarily deployed to sdlc July 4, 2024 14:08 — with GitHub Actions Inactive

Atrax1 marked this pull request as ready for review July 4, 2024 14:08

Atrax1 requested a review from a team as a code owner July 4, 2024 14:08

pavel-raykov reviewed Jul 4, 2024

View reviewed changes

doc(docker): update README

5b5711b

Atrax1 temporarily deployed to sdlc July 4, 2024 22:11 — with GitHub Actions Inactive

Atrax1 requested a review from pavel-raykov July 4, 2024 22:11

pavel-raykov reviewed Jul 5, 2024

View reviewed changes

pavel-raykov self-requested a review July 5, 2024 07:57

doc(docker): update README missing punctuation

7192daf

Atrax1 temporarily deployed to sdlc July 5, 2024 09:06 — with GitHub Actions Inactive

pavel-raykov approved these changes Jul 5, 2024

View reviewed changes

jmank88 approved these changes Jul 8, 2024

View reviewed changes

Atrax1 added this pull request to the merge queue Jul 8, 2024

Merged via the queue into develop with commit 4518ceb Jul 8, 2024
115 checks passed

Atrax1 deleted the BCF-3281-ability-to-deploy-node-using-docker-compose branch July 8, 2024 13:30

chainchad mentioned this pull request Jul 29, 2024

develop -> release/2.14.0 to fix merge conflicts #13944

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bcf 3281 ability to deploy node using docker compose #13721

Bcf 3281 ability to deploy node using docker compose #13721

Atrax1 commented Jun 28, 2024 •

edited by jira bot

Loading

github-actions bot commented Jul 2, 2024

pavel-raykov Jul 2, 2024

Atrax1 Jul 2, 2024

pavel-raykov Jul 2, 2024

pavel-raykov Jul 3, 2024 •

edited

Loading

Atrax1 Jul 4, 2024

pavel-raykov Jul 3, 2024

Atrax1 Jul 3, 2024

pavel-raykov Jul 3, 2024

Atrax1 Jul 4, 2024

pavel-raykov Jul 4, 2024

pavel-raykov Jul 4, 2024

Atrax1 Jul 4, 2024

pavel-raykov Jul 4, 2024

Atrax1 Jul 4, 2024

pavel-raykov Jul 4, 2024

Atrax1 Jul 4, 2024

pavel-raykov Jul 5, 2024

cl-sonarqube-production bot commented Jul 5, 2024


		cld Runs the chainlink node container in dev mode

		acceptance Run the services required to perform an acceptance test

Bcf 3281 ability to deploy node using docker compose #13721

Bcf 3281 ability to deploy node using docker compose #13721

Conversation

Atrax1 commented Jun 28, 2024 • edited by jira bot Loading

Requires Dependencies

Resolves Dependencies

github-actions bot commented Jul 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pavel-raykov Jul 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cl-sonarqube-production bot commented Jul 5, 2024

Quality Gate passed

Atrax1 commented Jun 28, 2024 •

edited by jira bot

Loading

pavel-raykov Jul 3, 2024 •

edited

Loading