add reorg tests for v23 #13749
Merged
add reorg tests for v23 #13749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
anirudhwarrier
approved these changes
Jul 16, 2024
| @@ -240,8 +240,9 @@ func (k *KeeperBenchmarkTest) Run() { | |||
| txKeyId = 0 | |||
| } | |||
| kr := k.keeperRegistries[rIndex] | |||
| // TODO: need to add the LINK, WETH and WETH/USD feed to support v23 | |||
There was a problem hiding this comment.
is this not done?
if so, can u create a ticket to track
There was a problem hiding this comment.
Yes, this is not done yet, Sync-ed with Anirudh this morning, and he is aware and gonna tackle this soon. Here is the ticket (AUTO-11119) for benchmark testing.
FelixFan1992
approved these changes
Jul 16, 2024
This was referenced Jul 17, 2024
This was referenced Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, added v23.
Reorg tests all pass: https://github.com/smartcontractkit/chainlink/actions/runs/9949996104/job/27487368646