No new finalized Heads Implementation #13907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanTinianov
previously approved these changes
Jul 24, 2024
amit-momin
reviewed
Jul 24, 2024
amit-momin
reviewed
Jul 24, 2024
amit-momin
reviewed
Jul 24, 2024
amit-momin
reviewed
Jul 24, 2024
Co-authored-by: amit-momin <108959691+amit-momin@users.noreply.github.com>
Co-authored-by: amit-momin <108959691+amit-momin@users.noreply.github.com>
Co-authored-by: amit-momin <108959691+amit-momin@users.noreply.github.com>
…hub.com:smartcontractkit/chainlink into feature/BCI-3731-no-new-finalized-block-develop
dimriou
reviewed
Jul 25, 2024
dimriou
reviewed
Jul 29, 2024
Comment on lines
+289
to
+291
| //n.stateMu.Lock() | ||
| //n.healthCheckSubs = append(n.healthCheckSubs, sub) | ||
| //n.stateMu.Unlock() |
There was a problem hiding this comment.
Are these placeholders?
There was a problem hiding this comment.
Yes, after merging the BCI-2875 result.sub = sub will be replaced with
n.stateMu.Lock()
n.healthCheckSubs = append(n.healthCheckSubs, sub)
n.stateMu.Unlock()
dimriou
reviewed
Jul 29, 2024
| if !n.onNewHead(lggr, &localHighestChainInfo, head) { | ||
| continue | ||
| } | ||
|
|
There was a problem hiding this comment.
nit: Can you add a one-line comment here to quickly explain how we use bitwise operators? i.e. "We clear NoNewHead sync issue, after receiving a new head and check for out of sync." or something along these lines. It took me some time to figure out what is going on, without context.
dimriou
reviewed
Jul 29, 2024
common/client/models.go
Outdated
Comment on lines
80
to
90
| type syncIssue int | ||
|
|
||
| const ( | ||
| // syncIssueNotInSyncWithPool - RPC is lagging behind the highest block observed within the pool of RPCs | ||
| syncIssueNotInSyncWithPool syncIssue = 1 << iota | ||
| // syncIssueNoNewHead - RPC failed to produce a new head for too long | ||
| syncIssueNoNewHead | ||
| // syncIssueNoNewFinalizedHead - RPC failed to produce a new finalized head for too long | ||
| syncIssueNoNewFinalizedHead | ||
| syncIssueLen | ||
| ) |
There was a problem hiding this comment.
Does changing syncIssue to syncStatus and adding synced state as 0 work, or does it mess up the enumeration incrementation? I noticed in outOfSyncLoop we use a 0 value instead of an enum value because of this.
…hub.com:smartcontractkit/chainlink into feature/BCI-3731-no-new-finalized-block-develop
|
dimriou
approved these changes
Jul 29, 2024
amit-momin
approved these changes
Jul 29, 2024
Tofel
pushed a commit
that referenced
this pull request
Jul 31, 2024
* No new finalized Heads Implementation * fixed tests * update defaults for NoNewFinalizedHeadsThreshold * Update common/client/node_lifecycle.go Co-authored-by: amit-momin <108959691+amit-momin@users.noreply.github.com> * Update common/client/node_lifecycle_test.go Co-authored-by: amit-momin <108959691+amit-momin@users.noreply.github.com> * Update common/client/node_lifecycle_test.go Co-authored-by: amit-momin <108959691+amit-momin@users.noreply.github.com> * rename HeadIsNotIncreasing to NoNewHead * move and add docs for syncIssue consts * rename syncIssue to syncStatus --------- Co-authored-by: amit-momin <108959691+amit-momin@users.noreply.github.com>
This was referenced Jul 31, 2024
This was referenced Aug 18, 2024
friedemannf
added a commit
to smartcontractkit/ccip
that referenced
this pull request
Aug 20, 2024
## Motivation Cherry-pick of smartcontractkit/chainlink#14021 cherry-pick of smartcontractkit/chainlink#13957 cherry-pick of smartcontractkit/chainlink#13876 cherry-pick of smartcontractkit/chainlink#13907
asoliman92
pushed a commit
that referenced
this pull request
Aug 28, 2024
* No new finalized Heads Implementation * fixed tests * update defaults for NoNewFinalizedHeadsThreshold * Update common/client/node_lifecycle.go Co-authored-by: amit-momin <108959691+amit-momin@users.noreply.github.com> * Update common/client/node_lifecycle_test.go Co-authored-by: amit-momin <108959691+amit-momin@users.noreply.github.com> * Update common/client/node_lifecycle_test.go Co-authored-by: amit-momin <108959691+amit-momin@users.noreply.github.com> * rename HeadIsNotIncreasing to NoNewHead * move and add docs for syncIssue consts * rename syncIssue to syncStatus --------- Co-authored-by: amit-momin <108959691+amit-momin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NoNewFinalizedHeadsThresholdExplanation of methodology to define
NoNewFinalizedHeadsThresholdis available hereDefault values were only set for chains that have
FinalityTagEnabled = truefor CCIP andNoNewHeadsThreshold > 0.