KS-391: Capabilities Registry Fixes #13937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cds95
force-pushed
the
KS-391/capabilities-registry-audit-fixes
branch
from
c414a5a to
76cb4bc
Compare
cds95
force-pushed
the
KS-391/capabilities-registry-audit-fixes
branch
from
76cb4bc to
6e2a249
Compare
…ging to another node operator
cds95
force-pushed
the
KS-391/capabilities-registry-audit-fixes
branch
from
6e2a249 to
a840f63
Compare
cds95
requested review from
archseer,
bolekk,
patrick-dowell and
a team
as code owners
|
archseer
approved these changes
Jul 29, 2024
DeividasK
approved these changes
Jul 29, 2024
Tofel
pushed a commit
that referenced
this pull request
Jul 31, 2024
* prevent malicious a node operator from taking over another node belonging to another node operator * prevent malicious node operator from becoming the admin for another node operator
This was referenced Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updateNodeOperatorsto checkmsg.senderagainst current admin instead of new adminupdateNodesto prevent a malicious node operator from taking over a node belonging to another node by calling the function and passing in the p2p ID of the node they are taking over.