-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(SHIP-2626) added custom error handling for Treasure #13981
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
53bd9c3
added custom error handling for Treasure
amaechiokolobi d241e55
added changeset
amaechiokolobi 153a6b1
fix
amaechiokolobi a5d3319
fixed test
amaechiokolobi a3788a3
moved Treasure error to Fatal
amaechiokolobi 39af087
added treasure fatal
amaechiokolobi 4b86126
fixed changeset
amaechiokolobi 9103640
add changeset
amaechiokolobi 6b51208
Merge branch 'develop' into ship-2626-treasure-errors
amaechiokolobi b58e808
removed extra changeset
amaechiokolobi b1dd44a
Merge branch 'ship-2626-treasure-errors' of github.com:smartcontractk…
amaechiokolobi 9663a97
Merge branch 'develop' into ship-2626-treasure-errors
amaechiokolobi c29adca
Merge branch 'develop' into ship-2626-treasure-errors
amaechiokolobi b73c8ea
added fatal error case test
amaechiokolobi 56eebb0
Merge branch 'develop' into ship-2626-treasure-errors
amaechiokolobi 381c675
changeset fix
amaechiokolobi b826d83
Merge branch 'ship-2626-treasure-errors' of github.com:smartcontractk…
amaechiokolobi de67877
removed unsed fatal errors
amaechiokolobi 1f16154
Merge branch 'develop' into ship-2626-treasure-errors
amaechiokolobi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"chainlink": minor | ||
--- | ||
|
||
error handling for Treasure #added |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like you have four separate error messages categorized for TreasureFatal, maybe add three others here in the test as well ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I just remove those as they were copied from Arbitrum and not relevant actually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, then you should keep it, as this case is unique for Treasure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left the
invalid chain id for signer
, and removed the others