Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ks-444: integrate keystone contract deployment #14334

Merged
merged 46 commits into from
Oct 9, 2024
Merged

ks-444: integrate keystone contract deployment #14334

merged 46 commits into from
Oct 9, 2024

Conversation

krehermann
Copy link
Contributor

@krehermann krehermann commented Sep 4, 2024 •
edited by jira bot
Loading

KS-444

This add keystone specific implementation for programmatically deploying and configuration contracts.

The primary new concept is CLO integration

  • keystone uses CLO to track nops, not the job distributor. the framework expects JD and this is an adapter between the two
  • The primary use case is to consume the data model of CLO (extended by KS-453 ) to construct don nodesets discuss above.
  • to implement the adapter in a reasonable timeframe, i had to copy the generated data model from clo into this repo. cleanup tracked in KS-455

@krehermann krehermann force-pushed the ks-444/contract-deploy branch from 6392df1 to d41407f Compare September 4, 2024 20:22
@krehermann krehermann force-pushed the ks-444/contract-deploy branch from 67b57d1 to 0099c5b Compare September 6, 2024 20:28
@krehermann krehermann changed the title working ks-444: integrate keystone contract deployment Sep 6, 2024
krehermann
krehermann commented Sep 6, 2024
View reviewed changes
integration-tests/deployment/clo/offchain_client_impl.go
@@ -0,0 +1,213 @@
package clo
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forked from clo repo until KS-455 can be tackled https://github.com/smartcontractkit/feeds-manager/tree/develop/api/models

krehermann
krehermann commented Sep 6, 2024
View reviewed changes
integration-tests/deployment/clo/testdata/chain_writer_nodes.json
@@ -0,0 +1,1446 @@
[
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testdata is just the output of fmscli get nodeOperators. https://github.com/smartcontractkit/feeds-manager/tree/develop?tab=readme-ov-file#chainlink-orchestrator-api-client

this kind of data will be input to the testnet deployment

@krehermann krehermann marked this pull request as ready for review September 6, 2024 21:44
@krehermann krehermann requested a review from a team as a code owner September 6, 2024 21:44
@krehermann krehermann requested a review from a team as a code owner September 10, 2024 21:02
@krehermann krehermann requested review from george-dorin and removed request for a team September 10, 2024 21:02
@krehermann krehermann requested a review from AnieeG October 9, 2024 13:18
connorwstein
connorwstein previously approved these changes Oct 9, 2024
View reviewed changes
integration-tests/deployment/keystone/changeset/0001_deploy_registry.go
kslib "github.com/smartcontractkit/chainlink/integration-tests/deployment/keystone"
)

func Apply0001(lggr logger.Logger, env deployment.Environment, ab deployment.AddressBook, registryChainSel uint64) (deployment.ChangesetOutput, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note - we found that leaving these unordered is actually easier. Since you will have multiple higher environments (staging/testnet/mainnet) where you may want to run them in different orders/skip some etc. Can take a look at the CCIP dir for naming there.

@krehermann krehermann enabled auto-merge October 9, 2024 13:46
archseer
archseer previously approved these changes Oct 9, 2024
View reviewed changes
@archseer
Copy link
Contributor

archseer commented Oct 9, 2024 •
edited
Loading

We probably want to add the keystone team as codeowners for integration-tests/deployment/keystone

chainlink/.github/CODEOWNERS

Line 108 in 002296d

# TODO: As more products add their deployment logic here, add the team as an owner

@krehermann krehermann added this pull request to the merge queue Oct 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 9, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
42 New issues
2 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
4.0% Duplication on New Code

See analysis details on SonarQube

@krehermann krehermann enabled auto-merge October 9, 2024 17:19
@krehermann krehermann added this pull request to the merge queue Oct 9, 2024
Merged via the queue into develop with commit 0ad6246 Oct 9, 2024
128 of 129 checks passed
@krehermann krehermann deleted the ks-444/contract-deploy branch October 9, 2024 17:50
@github-actions github-actions bot mentioned this pull request Oct 9, 2024
Draft
This was referenced Oct 21, 2024
Draft
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmank88 jmank88 jmank88 left review comments

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes

@connorwstein connorwstein connorwstein approved these changes

@archseer archseer archseer left review comments

@austinborn austinborn Awaiting requested review from austinborn

@george-dorin george-dorin Awaiting requested review from george-dorin george-dorin is a code owner automatically assigned from smartcontractkit/foundations

@bolekk bolekk Awaiting requested review from bolekk

@AnieeG AnieeG Awaiting requested review from AnieeG

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19

@vyzaldysanchez vyzaldysanchez Awaiting requested review from vyzaldysanchez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@krehermann @archseer @jmank88 @bolekk @connorwstein @vyzaldysanchez @cedric-cordenier @AnieeG