Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BCF-3381] - Implement changeset LatestHead #521 #14394

Merged
merged 18 commits into from
Sep 11, 2024
Merged

[BCF-3381] - Implement changeset LatestHead #521 #14394

merged 18 commits into from
Sep 11, 2024

Conversation

ilija42
Copy link
Contributor

@ilija42 ilija42 commented Sep 10, 2024 •
edited
Loading

This was referenced Sep 10, 2024
Merged
Merged
Merged
Merged
@ilija42 ilija42 force-pushed the BCF-3381-expose-latest-heads branch from 818ace6 to fddbd37 Compare September 11, 2024 09:21
@ilija42 ilija42 changed the title Implement ChainSet LatestHead [BCF-3381] - Implement changeset LatestHead #521 Sep 11, 2024
@ilija42 ilija42 marked this pull request as ready for review September 11, 2024 09:43
@ilija42 ilija42 requested review from a team as code owners September 11, 2024 09:43
@ilija42 ilija42 requested review from vyzaldysanchez and removed request for a team September 11, 2024 09:43
@ilija42 ilija42 force-pushed the BCF-3381-expose-latest-heads branch from 54b69d7 to 7c9e9ee Compare September 11, 2024 10:06
silaslenihan
silaslenihan previously approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@silaslenihan silaslenihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EasterTheBunny
EasterTheBunny previously approved these changes Sep 11, 2024
View reviewed changes
Farber98
Farber98 previously approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@Farber98 Farber98 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make generate should fix the CI Core / Clean Go Tidy & Generate (pull_request) check

@ilija42 ilija42 dismissed stale reviews from Farber98 and EasterTheBunny via 9fcc55f September 11, 2024 19:47
silaslenihan
silaslenihan previously approved these changes Sep 11, 2024
View reviewed changes
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
9.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@ilija42 ilija42 requested a review from a team September 11, 2024 20:25
@ilija42 ilija42 enabled auto-merge September 11, 2024 20:25
@jmank88
Copy link
Contributor

jmank88 commented Sep 11, 2024

If you use plain links, then they are formatted nicely with color and icons:

@ilija42 ilija42 added this pull request to the merge queue Sep 11, 2024
Merged via the queue into develop with commit 28989b3 Sep 11, 2024
137 checks passed
@ilija42 ilija42 deleted the BCF-3381-expose-latest-heads branch September 11, 2024 20:55
@github-actions github-actions bot mentioned this pull request Sep 11, 2024
Draft
@makramkd makramkd mentioned this pull request Sep 12, 2024
Closed
@github-actions github-actions bot mentioned this pull request Sep 20, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmank88 jmank88 jmank88 approved these changes

@silaslenihan silaslenihan silaslenihan approved these changes

@kidambisrinivas kidambisrinivas kidambisrinivas left review comments

@vyzaldysanchez vyzaldysanchez Awaiting requested review from vyzaldysanchez vyzaldysanchez is a code owner automatically assigned from smartcontractkit/foundations

@Farber98 Farber98 Awaiting requested review from Farber98

@EasterTheBunny EasterTheBunny Awaiting requested review from EasterTheBunny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ilija42 @jmank88 @kidambisrinivas @EasterTheBunny @silaslenihan @Farber98