DF-20481: Add new OCR3DataFeeds telemetry type for Mercury jobs #14470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinborn
requested review from
cedric-cordenier and
samsondav
and removed request for
a team
austinborn
commented
Sep 18, 2024
austinborn
changed the title
alecgard
previously approved these changes
Sep 18, 2024
alecgard
approved these changes
Sep 18, 2024
alecgard
reviewed
Sep 18, 2024
| return nil, fmt.Errorf("error while unmarshalling relay config: %w", err) | ||
| } | ||
|
|
||
| var err error |
There was a problem hiding this comment.
Nit: This could be defined where it is given a value, as we immediately return when there is an err rather than reference it later
There was a problem hiding this comment.
This doesn't seem work with the linter. When I remove this and set err := ... everywhere, I get this on line 129, 136, 143 and 150: factory declared and not used.
There was a problem hiding this comment.
Ah - we could move var err error to line 111 so that it is defined just for the factory methods, but I'm happy either way
|
samsondav
approved these changes
Sep 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
momentmaker
added a commit
that referenced
this pull request
Sep 19, 2024
* develop: (79 commits) core/config/toml: include value in InsecureConnection error message (#14495) vrf: add soneium config for integration tests (#14443) Add default test config for Grafana (#14475) Update to 1.5 RMN contract address (#14485) fix lint issues (#14450) [BCFR-203] Improve CR value comparator querying (topics and data words) by doing encoding in the relayer (#14207) integration-tests/deployment/ccip: fix assertion fns (#14482) chore: remove gha workflow validation (#14487) devsvcs-244: update token transfer (#14481) DF-20481: Add new OCR3DataFeeds telemetry type for Mercury jobs (#14470) Merc 6304 view function ea telem support (#14467) [DEVSVCS-545] cleanup (#14478) Mantle use vanilla l1 oracle (#14471) Fix E2E_TESTS_ON_GITHUB_CI.md (#14473) Upgrade chainlink ccip dependency (#14474) [DEVSVCS-545] automation benchmark test remove support for keepers v1 (#14472) Enables OOO Execution for E2E Tests (#14392) Delegate workflow spec creation (#14365) CCIP-3407: Add release testing configs (#1436) (#14463) Implement v0.3-compatible telemetry for LLO (#14440) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit: Add new OCR3DataFeeds telemetry type for Mercury jobs
Ticket: DF-20481
The main logic is:
This is so telemetry for the new Data Feeds jobs doesn't affect Streams product monitoring. Streams doesn't have a use case for EnableTriggerCapability since it only routes to servers at the moment, but if a Streams job has both transmit methods, it will then automatically route telemetry back to Streams.