CCIP-3420: Fix IsRequestTriggeredWithinTimeframe #14498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Motivation The prior approach to find if there is traffic in a lane was not detecting the transactions properly. It could be due to the `CCIPSendRequestedWatcher` captures the event after it is initiated not any transaction before that. ## Solution The revised approach is to use the FilterCCIPSendRequested by a past derived block number and see if there is any traffic. The block number is derived by this formula: `filterFromBlock = latestBlockNumber - (SkipRequestIfAnotherRequestTriggeredWithin/avgBlockTime)` By this approach, we will be able to find traffic better. https://smartcontract-it.atlassian.net/browse/CCIP-3420
b-gopalswami
changed the title
gheorghestrimtu
approved these changes
Sep 19, 2024
AnieeG
approved these changes
Sep 19, 2024
momentmaker
added a commit
that referenced
this pull request
Sep 19, 2024
…tractkit/chainlink into re-2964/goreleaser-ccip * 're-2964/goreleaser-ccip' of https://github.com/smartcontractkit/chainlink: Fix data race in TestLogPoller_Replay (#14431) Fix CCIP Load Test Faulty Fund Return (#14499) use tx in insertLogsWithinTx (#14361) Bring KMS client and multiclient over to chainlink (#14484) CCIP-3420: Fix IsRequestTriggeredWithinTimeframe (#1445) (#14498) [TT-1345] option to use predeployed contracts in OCR tests (#13758) CCIP-3428 Enabling ccip smoke test for testnet (#14452)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting this change from CCIP. PR: smartcontractkit/ccip#1445
Motivation
The prior approach to find if there is traffic in a lane was not detecting the transactions properly. It could be due to the
CCIPSendRequestedWatchercaptures the event after it is initiated not any transaction before that.Solution
The revised approach is to use the FilterCCIPSendRequested by a past derived block number and see if there is any traffic. The block number is derived by this formula:
filterFromBlock = latestBlockNumber - (SkipRequestIfAnotherRequestTriggeredWithin/avgBlockTime)By this approach, we will be able to find traffic better.https://smartcontract-it.atlassian.net/browse/CCIP-3420
Requires
Resolves