-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCIP-4130 CCIP-Compatible Generic BurnMintERC20 #15123
base: develop
Are you sure you want to change the base?
Conversation
Static analysis results are availableHey @jhweintraub, you can view Slither reports in the job summary here or download them as artifact here. |
Solidity Review Jira issueHey! We have taken the liberty to link this PR to a Jira issue for Solidity Review. This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one. Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: This PR has been linked to Solidity Review Jira issue: CCIP-3966 |
23b7473
to
0744916
Compare
AER Report: CI Coreaer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Find New Flaky Tests In Chainlink Project / Get Tests To Run , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , lint , Find New Flaky Tests In Deployment Project , Find New Flaky Tests In Chainlink Project / Run Tests , Find New Flaky Tests In Chainlink Project / Report , Flakey Test Detection , SonarQube Scan 1. Test failures encountered: go_core_testsSource of Error:
Why: The error occurred because some tests in the Suggested fix: Review the test output to identify which tests failed and address the underlying issues in the code or the tests themselves. Ensure all tests pass before re-running the action. AER Report: Operator UI CI ran successfully ✅ |
//go:generate go run ../generation/generate/wrap.go ../../../contracts/solc/v0.8.19/LinkToken/LinkToken.abi ../../../contracts/solc/v0.8.19/LinkToken/LinkToken.bin LinkToken link_token | ||
//go:generate go run ../generation/generate/wrap.go ../../../contracts/solc/v0.8.19/BurnMintERC20/BurnMintERC20.abi ../../../contracts/solc/v0.8.19/BurnMintERC20/BurnMintERC20.bin BurnMintERC20 burn_mint_erc20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wym? That we don't need it since we have the link_token and erc677? There's different functions which is why its included.
c861c21
to
0744916
Compare
a10ced4
to
d502b02
Compare
2c66f5c
to
dd7bb2b
Compare
…or check that only applied to 677" This reverts commit dce25c7.
# Conflicts: # contracts/gas-snapshots/ccip.gas-snapshot
8f88a4c
to
1202ea8
Compare
Generic BurnMintERC20 that is compatible with CCIPGetAdmin() functionality. Includes tests which are named and organized based on newly established naming conventions for tests. BurnMintERC20 implements OZ AccessControl instead of
Ownable2Step
but maintains a singular ccip admin