Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCIP-4130 CCIP-Compatible Generic BurnMintERC20 #15123

Open
wants to merge 47 commits into
base: develop
Choose a base branch
from

Conversation

jhweintraub
Copy link
Collaborator

@jhweintraub jhweintraub commented Nov 5, 2024

Generic BurnMintERC20 that is compatible with CCIPGetAdmin() functionality. Includes tests which are named and organized based on newly established naming conventions for tests. BurnMintERC20 implements OZ AccessControl instead of Ownable2Step but maintains a singular ccip admin

@jhweintraub jhweintraub requested a review from a team as a code owner November 5, 2024 16:26
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Static analysis results are available

Hey @jhweintraub, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Solidity Review Jira issue

Hey! We have taken the liberty to link this PR to a Jira issue for Solidity Review.

This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one.
Please reach out to the Test Tooling team and notify them about any issues you encounter.

Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: contracts/.changeset/hot-pandas-carry.md

This PR has been linked to Solidity Review Jira issue: CCIP-3966

Copy link
Contributor

github-actions bot commented Nov 6, 2024

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Find New Flaky Tests In Chainlink Project / Get Tests To Run , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , lint , Find New Flaky Tests In Deployment Project , Find New Flaky Tests In Chainlink Project / Run Tests , Find New Flaky Tests In Chainlink Project / Report , Flakey Test Detection , SonarQube Scan

1. Test failures encountered: go_core_tests

Source of Error:
Run tests	2024-11-14T16:44:08.7387869Z Encountered test failures.
Run tests	2024-11-14T16:44:08.7388355Z go_core_tests exiting with code 1
Run tests	2024-11-14T16:44:08.7408375Z ##[error]Process completed with exit code 1.

Why: The error occurred because some tests in the go_core_tests suite failed. The exit code 1 indicates that the test runner encountered one or more test failures.

Suggested fix: Review the test output to identify which tests failed and address the underlying issues in the code or the tests themselves. Ensure all tests pass before re-running the action.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@jhweintraub jhweintraub requested a review from a team as a code owner November 6, 2024 23:53
//go:generate go run ../generation/generate/wrap.go ../../../contracts/solc/v0.8.19/LinkToken/LinkToken.abi ../../../contracts/solc/v0.8.19/LinkToken/LinkToken.bin LinkToken link_token
//go:generate go run ../generation/generate/wrap.go ../../../contracts/solc/v0.8.19/BurnMintERC20/BurnMintERC20.abi ../../../contracts/solc/v0.8.19/BurnMintERC20/BurnMintERC20.bin BurnMintERC20 burn_mint_erc20
Copy link
Collaborator Author

@jhweintraub jhweintraub Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wym? That we don't need it since we have the link_token and erc677? There's different functions which is why its included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants