Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support different decimals #15310

Merged
merged 6 commits into from
Nov 22, 2024
Merged

support different decimals #15310

merged 6 commits into from
Nov 22, 2024

Conversation

RensR
Copy link
Contributor

@RensR RensR commented Nov 19, 2024

Introduce support for different decimals on different chains

@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to contracts. Please run pnpm changeset in the contracts directory to add a changeset.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024 •
edited
Loading

Static analysis results are available

Hey @RensR, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.

@smartcontractkit smartcontractkit deleted a comment from github-actions bot Nov 19, 2024
@RensR RensR force-pushed the CCIP-4269-make-pools-swappable branch from f17e34d to 1369053 Compare November 20, 2024 12:38
@jhweintraub jhweintraub mentioned this pull request Nov 20, 2024
Merged
@RensR RensR force-pushed the CCIP-4156-solana-compatible-pools branch from c67cf0d to 1733801 Compare November 22, 2024 13:39
@RensR RensR marked this pull request as ready for review November 22, 2024 13:41
@RensR RensR requested review from a team as code owners November 22, 2024 13:41
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@RensR RensR force-pushed the CCIP-4156-solana-compatible-pools branch from 1c85b29 to 9880f64 Compare November 22, 2024 13:59
@RensR RensR requested a review from a team as a code owner November 22, 2024 13:59
@RensR RensR requested review from winder, rstout, asoliman92, makramkd, dimkouv and mateusz-sekara and removed request for a team November 22, 2024 13:59
@RensR RensR requested a review from 0xAustinWang November 22, 2024 13:59
@RensR RensR merged commit 2e6c5fd into CCIP-4269-make-pools-swappable Nov 22, 2024
95 of 99 checks passed
@RensR RensR deleted the CCIP-4156-solana-compatible-pools branch November 22, 2024 14:08
github-merge-queue bot pushed a commit that referenced this pull request Nov 22, 2024
@kylesmartin @RensR
@jhweintraub @app-token-issuer-infra-releng
CCIP-4269 - Make registered TokenPools swappable (#15293)
545e6dd 
* store hash of (dest chain selector, remote pool) to do lookup

* fill in coverage gaps and fix zero address check

* remove comment

* Update gethwrappers

* reduce test code

* add test multiple remote pools

* improve tests

* rename and rm EVM specific checks

* [Bot] Update changeset file with jira issues

* fix offchain tests

* use mapping over set

* move remotePools mapping to RemoteChainConfig

* use bytes32 set over bytes mapping

* fix ci

* allow multiple pools on remote chain config

* support different decimals (#15310)

* use calldata over memory, extract isRemotePool

* support different decimals

* pass in decimals

* add tests

* fix liqman, tests, gen code

* fix offchain

* add comment, changeset and fix lint

* turn off 1.4 test

* CCIP-4331 update factory contract to use new arbitrary token decimals in constructor (#15337)

* support different decimals

* pass in decimals

* add tests

* gen wrappers

* update factory contract to use new arbitrary token decimals in constructor

* snapshot fix

---------

Co-authored-by: Rens Rooimans <github@rensrooimans.nl>

---------

Co-authored-by: Rens Rooimans <github@rensrooimans.nl>
Co-authored-by: Josh <josh.weintraub@smartcontract.com>
Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com>
Co-authored-by: Josh Weintraub <26035072+jhweintraub@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Nov 22, 2024
@kylesmartin @RensR
@jhweintraub @app-token-issuer-infra-releng
CCIP-4269 - Make registered TokenPools swappable (#15293)
4665863 
* store hash of (dest chain selector, remote pool) to do lookup

* fill in coverage gaps and fix zero address check

* remove comment

* Update gethwrappers

* reduce test code

* add test multiple remote pools

* improve tests

* rename and rm EVM specific checks

* [Bot] Update changeset file with jira issues

* fix offchain tests

* use mapping over set

* move remotePools mapping to RemoteChainConfig

* use bytes32 set over bytes mapping

* fix ci

* allow multiple pools on remote chain config

* support different decimals (#15310)

* use calldata over memory, extract isRemotePool

* support different decimals

* pass in decimals

* add tests

* fix liqman, tests, gen code

* fix offchain

* add comment, changeset and fix lint

* turn off 1.4 test

* CCIP-4331 update factory contract to use new arbitrary token decimals in constructor (#15337)

* support different decimals

* pass in decimals

* add tests

* gen wrappers

* update factory contract to use new arbitrary token decimals in constructor

* snapshot fix

---------

Co-authored-by: Rens Rooimans <github@rensrooimans.nl>

---------

Co-authored-by: Rens Rooimans <github@rensrooimans.nl>
Co-authored-by: Josh <josh.weintraub@smartcontract.com>
Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com>
Co-authored-by: Josh Weintraub <26035072+jhweintraub@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chainchad chainchad chainchad approved these changes

@winder winder Awaiting requested review from winder winder was automatically assigned from smartcontractkit/ccip-offchain

@rstout rstout Awaiting requested review from rstout rstout was automatically assigned from smartcontractkit/ccip-offchain

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 was automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd was automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv was automatically assigned from smartcontractkit/ccip-offchain

@mateusz-sekara mateusz-sekara Awaiting requested review from mateusz-sekara mateusz-sekara was automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang was automatically assigned from smartcontractkit/ccip-offchain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RensR @chainchad