Add explorer to yarn workspaces #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupurt
force-pushed
the
chores/explorer-client-in-yarn-workspace
branch
from
1d5c63c to
1bc889b
Compare
rupurt
commented
Aug 16, 2019
| @@ -16,7 +16,7 @@ | |||
| "esModuleInterop": true, | |||
| "noImplicitAny": true, | |||
| "baseUrl": ".", | |||
| "typeRoots": ["node_modules/@types", "@types"] | |||
| "typeRoots": ["node_modules/@types", "../node_modules/@types", "@types"] | |||
There was a problem hiding this comment.
ts-jest doesn't support yarn workspaces. Need to configure install location of typescript
rupurt
commented
Aug 16, 2019
explorer/package.json
Outdated
| "private": true, | ||
| "version": "0.0.0", | ||
| "description": "LINK Explorer", | ||
| "author": "Chainlink Dev Team", | ||
| "license": "MIT", | ||
| "keywords": [], | ||
| "scripts": { | ||
| "dev": "yarn autosetup && concurrently \"cd client && yarn start\" \"ts-node-dev --respawn --transpileOnly ./src/index.ts\"", | ||
| "dev": "yarn automigrate && concurrently \"cd client && yarn start\" \"ts-node-dev --respawn --transpileOnly ./src/index.ts\"", |
There was a problem hiding this comment.
Challenging to support autosetup within yarn workspace so I removed it. Open to thoughts on how we can achieve this is we still want it.
There was a problem hiding this comment.
Should be fine to just leave it in the base package.json and out of any of the sub projects?
There was a problem hiding this comment.
@j16r I stumbled across npm pre & post hooks and used them instead.
rupurt
force-pushed
the
chores/explorer-client-in-yarn-workspace
branch
from
1bc889b to
4ede71c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Finishes #166833262]