controllers: Fix checking errors via ErrorNotFound #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the Cause(..) of the error for checking against the ErrorNotFound value. This prevents future regressions where the underlying function may Wrap(..) the returned error, causing the condition to fail when it should not.
j16r
approved these changes
Aug 19, 2019
mateusz-sekara
pushed a commit
that referenced
this pull request
Jan 10, 2025
Epic: https://smartcontract-it.atlassian.net/browse/CCIP-3488 ## Description Added LBTC smart contract reader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the Cause(..) of the error for checking against the ErrorNotFound value.
This prevents future regressions where the underlying function may Wrap(..) the returned error, causing the condition to fail when it should not.