Add common rmn config struct #15597
Merged
Add common rmn config struct #15597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnieeG
reviewed
Dec 10, 2024
deployment/ccip/config/rmn.go
Outdated
| @@ -0,0 +1,39 @@ | |||
| package config | |||
There was a problem hiding this comment.
does it make sense to move it under https://github.com/smartcontractkit/chainlink/blob/9d8d9f48b92cab72de51e4484cc7b0833b1ccf6b/deployment/ccip/changeset/cs_update_rmn_config.go ? It will help locate all pieces together
There was a problem hiding this comment.
Yeah good idea, I will make the change
There was a problem hiding this comment.
Also it would be nice if you can get the test to use these configs
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
AnieeG
approved these changes
Dec 10, 2024
connorwstein
approved these changes
Dec 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
george-dorin
pushed a commit
that referenced
this pull request
Jan 13, 2025
* Add common rmn config struct * Move to RMN changeset * Add test using RMNConfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add common rmn config struct