Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration logging can be enabled independently of all sql logging #1563

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

j16r
Copy link
Contributor

@j16r j16r commented Aug 22, 2019

SQL logging implies migration logging, migration logging is a "subset". This should make the tests a lot less verbose.

SQL logging implies migration logging, migration logging is a "subset".
Copy link
Contributor

@rupurt rupurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌵

@@ -98,6 +98,8 @@ func NewConfigWithWSServer(t testing.TB, wsserver *httptest.Server) *TestConfig
rawConfig.Set("CHAINLINK_DEV", true)
rawConfig.Set("ETH_GAS_BUMP_THRESHOLD", 3)
rawConfig.Set("LOG_LEVEL", orm.LogLevel{Level: zapcore.DebugLevel})
rawConfig.Set("LOG_SQL", false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@j16r j16r merged commit fe3497e into develop Aug 22, 2019
@j16r j16r deleted the feature/migration_logging_separate_toggle branch August 22, 2019 19:07
mateusz-sekara pushed a commit that referenced this pull request Jan 10, 2025
## Motivation
Adding two E2E test to validate Lombard integration.

Test-1: Make sure the destination payload data from mock token pool is
sent as 32 bytes and that triggers call attestation API enabled flow.
Mock attestation API provides the required attestation and token
transfer should be successful.

Test-2: Send non 32 bytes destination payload data form mock token pool
and that should trigger attestation disabled flow and the token transfer
should be successful.

## Solution

---------

Co-authored-by: Ryan Stout <ryan.stout@smartcontract.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants