-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add solana support to contract transmitter #15869
Add solana support to contract transmitter #15869
Conversation
offRampAddr = hexutil.Encode(addr) | ||
case relay.NetworkSolana: | ||
offRampAddr = solana.PublicKeyFromBytes(addr).String() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to error or panic here if encounter an unknown family. That will make it explicit to developers to support a new family here too, instead of silently returning null string.
AER Report: CI Core ran successfully ✅AER Report: Operator UI CIaer_workflow , commit , Breaking Changes GQL Check 1. Workflow failed to complete successfully:[convictional/trigger-workflow-and-wait@f69fa9e]Source of Error:
Why: The triggered workflow did not complete successfully. The conclusion status was "failure" instead of "success," which caused the upstream job to propagate the failure. Suggested fix: Investigate the logs of the triggered workflow at https://github.com/smartcontractkit/operator-ui/actions/runs/12757731294 to identify the specific reason for the failure and address the underlying issue. |
Quality Gate passedIssues Measures |
Jira ticket
This PR removes EVM dependent code (specifically the address encoding logic) in plugin oracle creator + contract transmitter. There will be two separate PR for refactoring CR+CW logic.