Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solana support to contract transmitter #15869

Conversation

huangzhen1997
Copy link
Contributor

@huangzhen1997 huangzhen1997 commented Jan 8, 2025

Jira ticket

This PR removes EVM dependent code (specifically the address encoding logic) in plugin oracle creator + contract transmitter. There will be two separate PR for refactoring CR+CW logic.

@huangzhen1997 huangzhen1997 marked this pull request as ready for review January 8, 2025 20:17
@huangzhen1997 huangzhen1997 requested a review from a team as a code owner January 8, 2025 20:17
offRampAddr = hexutil.Encode(addr)
case relay.NetworkSolana:
offRampAddr = solana.PublicKeyFromBytes(addr).String()
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to error or panic here if encounter an unknown family. That will make it explicit to developers to support a new family here too, instead of silently returning null string.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI

aer_workflow , commit , Breaking Changes GQL Check

1. Workflow failed to complete successfully:[convictional/trigger-workflow-and-wait@f69fa9e]

Source of Error:
Run convictional/trigger-workflow-and-wait@f69fa9eedd3c62a599220f4d5745230e237904be	2025-01-13T23:05:07.7825834Z Checking conclusion [failure]
Run convictional/trigger-workflow-and-wait@f69fa9eedd3c62a599220f4d5745230e237904be	2025-01-13T23:05:07.7826299Z Checking status [completed]
Run convictional/trigger-workflow-and-wait@f69fa9eedd3c62a599220f4d5745230e237904be	2025-01-13T23:05:07.7826628Z Conclusion is not success, it's [failure].
Run convictional/trigger-workflow-and-wait@f69fa9eedd3c62a599220f4d5745230e237904be	2025-01-13T23:05:07.7826984Z Propagating failure to upstream job

Why: The triggered workflow did not complete successfully. The conclusion status was "failure" instead of "success," which caused the upstream job to propagate the failure.

Suggested fix: Investigate the logs of the triggered workflow at https://github.com/smartcontractkit/operator-ui/actions/runs/12757731294 to identify the specific reason for the failure and address the underlying issue.

@huangzhen1997 huangzhen1997 changed the base branch from develop to solana-offchain-plugin January 9, 2025 19:49
@archseer archseer merged commit 016f5a6 into solana-offchain-plugin Jan 14, 2025
179 of 181 checks passed
@archseer archseer deleted the NONEVM-945/refactor-contract-transmitter-to-support-solana branch January 14, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants