Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DefaultCapConfig into multiple funcs #15882

Merged
merged 28 commits into from
Jan 28, 2025
Merged

Refactor DefaultCapConfig into multiple funcs #15882

merged 28 commits into from
Jan 28, 2025
+169 −124

Conversation

vyzaldysanchez
Copy link
Contributor

Requires

Supports

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

krehermann
krehermann reviewed Jan 9, 2025
View reviewed changes
deployment/keystone/changeset/internal/deploy.go Outdated Show resolved Hide resolved
deployment/keystone/changeset/internal/deploy.go Outdated Show resolved Hide resolved
deployment/keystone/changeset/internal/deploy.go Outdated Show resolved Hide resolved
deployment/keystone/changeset/internal/deploy.go Outdated Show resolved Hide resolved
@vyzaldysanchez vyzaldysanchez marked this pull request as ready for review January 16, 2025 16:05
@vyzaldysanchez vyzaldysanchez requested review from a team as code owners January 16, 2025 16:05
@vyzaldysanchez vyzaldysanchez requested review from a team as code owners January 16, 2025 16:05
bolekk
bolekk reviewed Jan 20, 2025
View reviewed changes
deployment/keystone/changeset/internal/deploy.go Outdated
@@ -1079,3 +1046,28 @@ func configureForwarder(lggr logger.Logger, chain deployment.Chain, contractSet
}
return opMap, nil
}

func GetDefaultCapConfig(capability capabilities_registry.CapabilitiesRegistryCapability) *capabilitiespb.CapabilityConfig {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only used by tests, right? If so, it should exist in the test subdirectory.

@vyzaldysanchez vyzaldysanchez requested a review from bolekk January 21, 2025 06:05
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
2 New issues
6 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

krehermann
krehermann approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@krehermann krehermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the jira ticket in the PR comment

@vyzaldysanchez
Copy link
Contributor Author

Jira Ticket: https://smartcontract-it.atlassian.net/browse/CRE-58

EasterTheBunny
EasterTheBunny approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@EasterTheBunny EasterTheBunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vyzaldysanchez vyzaldysanchez added this pull request to the merge queue Jan 28, 2025
Merged via the queue into develop with commit dc4c33f Jan 28, 2025
177 of 178 checks passed
@vyzaldysanchez vyzaldysanchez deleted the task/CRE-58/generalize-default-cap-config branch January 28, 2025 16:50
bolekk
bolekk reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@bolekk bolekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolekk bolekk bolekk left review comments

@krehermann krehermann krehermann approved these changes

@EasterTheBunny EasterTheBunny EasterTheBunny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vyzaldysanchez @bolekk @EasterTheBunny @krehermann