Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(core/scripts): removes panic and adds node public keys to peer #15950

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

MStreet3
Copy link
Contributor

@MStreet3 MStreet3 commented Jan 16, 2025

The CapabilitiesRegistry contract requires that the peers have an encryptionPublicKey field or else the transaction will revert. This PR adds the hardcoded node's EPK to create the node params before calling addNodes.

Requires

Supports

@MStreet3 MStreet3 marked this pull request as ready for review January 16, 2025 13:46
@MStreet3 MStreet3 requested review from a team as code owners January 16, 2025 13:46
@MStreet3 MStreet3 requested a review from agparadiso January 16, 2025 13:46
Copy link
Contributor

I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

agparadiso
agparadiso previously approved these changes Jan 16, 2025
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@justinkaseman justinkaseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MStreet3 MStreet3 added this pull request to the merge queue Jan 16, 2025
Merged via the queue into develop with commit f9dd7e1 Jan 16, 2025
170 of 171 checks passed
@MStreet3 MStreet3 deleted the fix/cap-reg-script branch January 16, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants