Skip to content

Conversation

@faisal-chainlink
Copy link

@faisal-chainlink faisal-chainlink commented May 7, 2025

Adds the Sui keystore to core

Requires

@faisal-chainlink faisal-chainlink requested a review from cfal May 9, 2025 07:11
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2025

I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@faisal-chainlink faisal-chainlink marked this pull request as ready for review May 9, 2025 12:25
@faisal-chainlink faisal-chainlink requested review from a team as code owners May 9, 2025 12:25
@faisal-chainlink faisal-chainlink force-pushed the feature/sui-keystore branch 2 times, most recently from ff72943 to 2515808 Compare May 15, 2025 17:19
@github-actions
Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and 2515808 (feature/sui-keystore).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

12 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestShell_SuiKeys 0% true false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/cmd true 0s Unknown
TestShell_SuiKeys/ListSuiKeys 0% true false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/cmd true 860ms Unknown
Test_SuiKeyStore_E2E/adds_an_externally_created_key_/_deletes_a_key 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/keystore true 0s @smartcontractkit/foundations, @smartcontractkit/core
Test_SuiKeyStore_E2E/imports_and_exports_a_key 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/keystore true 0s @smartcontractkit/foundations, @smartcontractkit/core
TestETHKeysController_ChainFailure_InvalidEnabled 66.6667% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/v2/core/web false 1.47s Unknown
TestSuiKeysController_Create_HappyPath 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/web false 1.466666666s Unknown
TestSuiKeysController_Delete_HappyPath 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/web false 120ms Unknown
TestSuiKeysController_Delete_NonExistentSuiKeyID 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/web false 140ms Unknown
TestSuiKeysController_Index_HappyPath 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/web false 123.333333ms Unknown
TestResolver_SuiKeys/no_keys_returned_by_GetAll 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/web/resolver false 113.333333ms @smartcontractkit/deployment-automation, @smartcontractkit/foundations, @smartcontractkit/core
TestResolver_SuiKeys/not_authorized 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/web/resolver false 110ms @smartcontractkit/deployment-automation, @smartcontractkit/foundations, @smartcontractkit/core
TestResolver_SuiKeys/success 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/web/resolver false 83.333333ms @smartcontractkit/deployment-automation, @smartcontractkit/foundations, @smartcontractkit/core

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@cfal cfal force-pushed the feature/sui-keystore branch from 2515808 to 48a5dfd Compare May 21, 2025 10:18
@cfal cfal requested review from a team as code owners May 21, 2025 10:18
@cfal cfal changed the base branch from develop to ccip-aptos-codec May 21, 2025 10:18
@cfal cfal marked this pull request as draft May 21, 2025 10:19
@cfal cfal force-pushed the ccip-aptos-codec branch 3 times, most recently from 18c2b60 to 4990063 Compare May 26, 2025 12:05
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
15.7% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube

@stackman27
Copy link
Contributor

addressed #19848

@stackman27 stackman27 closed this Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build-publish Build and Publish image to SDLC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants