Skip to content

Conversation

@github-actions
Copy link
Contributor

This PR is stale because it has been open days with no activity.
Remove the stale label, comment, or update this PR to prevent this PR from being closed in days.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@jmank88 jmank88 marked this pull request as ready for review September 16, 2025 11:53
@jmank88 jmank88 requested review from a team as code owners September 16, 2025 11:53
pavel-raykov
pavel-raykov previously approved these changes Sep 16, 2025
@jmank88
Copy link
Contributor Author

jmank88 commented Sep 16, 2025

I don't understand why some tests are still trying to run make install-loopinstall. Are they using the wrong commit?

@jmank88 jmank88 enabled auto-merge September 16, 2025 13:19
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored make install-loopinstall since it is used from outside this repo. We can circle back later.

-- out.txt --
ok Aptos.42.RelayerService
ok Aptos.42.RelayerService.PluginRelayerClient
ok Aptos.42.RelayerService.PluginRelayerClient.PluginAptos
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like aptos is either not starting cleanly, or the health report is not wired through... 🤔

@jmank88 jmank88 added this pull request to the merge queue Sep 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 16, 2025
@jmank88 jmank88 added this pull request to the merge queue Sep 16, 2025
Merged via the queue into develop with commit 93740bd Sep 16, 2025
162 of 163 checks passed
@jmank88 jmank88 deleted the install-more-loops branch September 16, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants