[CRE-533] Update Fake Consensus to support mode-switch and report-gen #18456
Conversation
|
👋 @bolekk, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
bolekk
force-pushed
the
chore/CRE-533-fake-consensus-update
branch
from
c964643 to
5c7eca2
Compare
bolekk
force-pushed
the
chore/CRE-533-fake-consensus-update
branch
from
5c7eca2 to
de3f123
Compare
|
| } | ||
| caps = append(caps, streamsTrigger) | ||
|
|
||
| httpAction := fakes.NewDirectHTTPAction(lggr) |
There was a problem hiding this comment.
@justinkaseman , @akhilchainani please confirm that it's OK to get those back. I'm not sure why you removed them in an earlier PR.
There was a problem hiding this comment.
yeah add them back, idk how they got removed. Probably by accident, sorry about that
| var _ commonCap.ExecutableCapability = (*DirectHTTPAction)(nil) | ||
|
|
||
| const HTTPActionID = "http-action@1.0.0" | ||
| const HTTPActionID = "http-actions@0.1.0" |
There was a problem hiding this comment.
is this the new id used in the sdk?
There was a problem hiding this comment.
It seems like. That's what a freshly-built workflow asks for...
| } | ||
| caps = append(caps, streamsTrigger) | ||
|
|
||
| httpAction := fakes.NewDirectHTTPAction(lggr) |
There was a problem hiding this comment.
yeah add them back, idk how they got removed. Probably by accident, sorry about that
| return response, nil | ||
| } | ||
|
|
||
| func (fh *DirectHTTPAction) Start(ctx context.Context) error { |
There was a problem hiding this comment.
How do we start caps now without this?
There was a problem hiding this comment.
This was actually a bug - overriding Start() and Close() from the underlying Service object. @justinkaseman 's test was failing. Start() and Close() are still there and if we want to customize they need to be named differently (e.g. lowercase)
5 participants
No description provided.