Add Channel Definition Opts to LLO capability_trigger report type to enable Stream Multiplication #18463

cawthorne · 2025-07-03T14:07:22Z

capability_trigger report type doesn't support an Opts field.

This PR adds a now optional Opts field, where all of the StreamIDs in the channel must be specified in a Multipliers array, in the correct order to match the order of the Streams array e.g.

"opts": {
    "multipliers": [
        {
            "multiplier": "1",
            "streamID": 1000000001,
        },
        {
            "multiplier": "1000000000000000000",
            "streamID": 1000000002,
        },
        {
            "multiplier": "1000000000000000000",
            "streamID": 1000000003,
        },
        {
            "multiplier": "1000000000000000000",
            "streamID": 1000000004,
        },
    ],
}

The inner multiplier field is a required variable.

This PR also is related to this PR:
smartcontractkit/chainlink-common#1282

Where the rollout plan for this new direction is defined.

…iplication

github-actions · 2025-07-03T14:07:38Z

👋 @cawthorne, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

fmunshi

Approved for streams eng

bolekk

LLO aggregator currently multiplies by 10^18. How are you planning to roll it out?

bolekk · 2025-07-04T02:33:57Z

core/services/llo/cre/report_codec.go

 	return b, nil
 }

 func (r ReportCodecCapabilityTrigger) Verify(cd llotypes.ChannelDefinition) error {


When is Verify() called?

https://github.com/smartcontractkit/chainlink-data-streams/blob/a98fa6515eae458fbff0c7e90222288eaf35935d/llo/channel_definitions.go#L33

Every observation round:
https://github.com/smartcontractkit/chainlink-data-streams/blob/a98fa6515eae458fbff0c7e90222288eaf35935d/llo/plugin.go#L390
https://github.com/smartcontractkit/chainlink-data-streams/blob/a98fa6515eae458fbff0c7e90222288eaf35935d/llo/plugin_observation.go#L51
https://github.com/smartcontractkit/chainlink-data-streams/blob/a98fa6515eae458fbff0c7e90222288eaf35935d/llo/plugin_observation.go#L90

…eport type

cawthorne · 2025-07-07T12:54:20Z

@smartcontractkit/keystone @smartcontractkit/capabilities-team

…enable Stream Multiplication (#18463) * Add Channel Definition Opts to LLO capability_trigger report for Multiplication * Fix lint errors + add changeset * lint * Make Opts and Opts.Multipliers.Multiplier required * Use errors.New instead * Make Opts non required * fix import order error * fix import order error * Remove omitempty from Opts.Multipliers * Make Capability LLO Integration test use capability_trigger channel report type * fixup comment * Make multiplier always 1e18 in Test_runLLOWorkflow test * only multiply by 1 * Add core/capabilities/integration_tests/keystone/llo_feed_test.go comment wtr to 1 using Multiplier in test * typo

…enable Stream Multiplication (#18463) * Add Channel Definition Opts to LLO capability_trigger report for Multiplication * Fix lint errors + add changeset * lint * Make Opts and Opts.Multipliers.Multiplier required * Use errors.New instead * Make Opts non required * fix import order error * fix import order error * Remove omitempty from Opts.Multipliers * Make Capability LLO Integration test use capability_trigger channel report type * fixup comment * Make multiplier always 1e18 in Test_runLLOWorkflow test * only multiply by 1 * Add core/capabilities/integration_tests/keystone/llo_feed_test.go comment wtr to 1 using Multiplier in test * typo (cherry picked from commit 85f86fa) Signed-off-by: Gregory Cawthorne <gregory.cawthorne@smartcontract.com>

…enable Stream Multiplication (#18463) * Add Channel Definition Opts to LLO capability_trigger report for Multiplication * Fix lint errors + add changeset * lint * Make Opts and Opts.Multipliers.Multiplier required * Use errors.New instead * Make Opts non required * fix import order error * fix import order error * Remove omitempty from Opts.Multipliers * Make Capability LLO Integration test use capability_trigger channel report type * fixup comment * Make multiplier always 1e18 in Test_runLLOWorkflow test * only multiply by 1 * Add core/capabilities/integration_tests/keystone/llo_feed_test.go comment wtr to 1 using Multiplier in test * typo

Add Channel Definition Opts to LLO capability_trigger report for Mult…

7550270

…iplication

cawthorne requested review from a team as code owners July 3, 2025 14:07

cawthorne changed the title ~~Add Channel Definition Opts to LLO capability_trigger report for Mult…~~ Add Channel Definition Opts to LLO capability_trigger report for Multiplication Jul 3, 2025

cawthorne marked this pull request as draft July 3, 2025 14:10

cawthorne changed the title ~~Add Channel Definition Opts to LLO capability_trigger report for Multiplication~~ Add Channel Definition Opts to LLO capability_trigger report type for Multiplication Jul 3, 2025

cawthorne changed the title ~~Add Channel Definition Opts to LLO capability_trigger report type for Multiplication~~ Add Channel Definition Opts to LLO capability_trigger report type to enable Stream Multiplication Jul 3, 2025

cawthorne added 7 commits July 3, 2025 15:54

Fix lint errors + add changeset

788f3f5

lint

60a4738

Make Opts and Opts.Multipliers.Multiplier required

68c3789

Use errors.New instead

c275b8b

Make Opts non required

d02f4ce

fix import order error

d01efc4

fix import order error

b7a2160

cawthorne marked this pull request as ready for review July 3, 2025 18:59

cawthorne requested a review from a team as a code owner July 3, 2025 18:59

cawthorne requested a review from jmank88 July 3, 2025 18:59

Remove omitempty from Opts.Multipliers

8e61182

fmunshi previously approved these changes Jul 3, 2025

View reviewed changes

jmank88 previously approved these changes Jul 3, 2025

View reviewed changes

cawthorne added this pull request to the merge queue Jul 3, 2025

cawthorne mentioned this pull request Jul 3, 2025

Remove CRE Capability Aggregator scaling smartcontractkit/chainlink-common#1282

Merged

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 3, 2025

bolekk previously approved these changes Jul 4, 2025

View reviewed changes

cawthorne added this pull request to the merge queue Jul 4, 2025

cawthorne removed this pull request from the merge queue due to a manual request Jul 4, 2025

cawthorne added this pull request to the merge queue Jul 4, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 4, 2025

Make Capability LLO Integration test use capability_trigger channel r…

5987d5b

…eport type

cawthorne requested review from fmunshi and jmank88 July 5, 2025 10:18

MStreet3 approved these changes Jul 7, 2025

View reviewed changes

fmunshi approved these changes Jul 7, 2025

View reviewed changes

cawthorne added this pull request to the merge queue Jul 7, 2025

Merged via the queue into develop with commit 85f86fa Jul 7, 2025
213 of 215 checks passed

cawthorne deleted the feature/add-channel-definition-multiplication-to-capability-trigger-llo-report-type branch July 7, 2025 16:48

github-actions bot mentioned this pull request Jul 7, 2025

[DO NOT MERGE] Changeset Release Preview - v2.33.0 #13148

Draft

github-actions bot mentioned this pull request Jul 9, 2025

[DO NOT MERGE] Changeset Release Preview - v2.27.0 chimaira88/chainlink#1

Merged

github-actions bot mentioned this pull request May 26, 2025

[DO NOT MERGE] Changeset Release Preview - v2.30.0 luisriverag/chainlink#572

Draft

This was referenced Jun 4, 2025

[DO NOT MERGE] Changeset Release Preview - v2.33.0 mikeyhodl/chainlink#830

Draft

[DO NOT MERGE] Changeset Release Preview - v2.33.0 MarcelRaschke/chainlink#6

Draft

github-actions bot mentioned this pull request Jul 25, 2025

[DO NOT MERGE] Changeset Release Preview - v2.29.0 JSTONE1111/chainlink#1

Merged

github-actions bot mentioned this pull request Aug 21, 2025

[DO NOT MERGE] Changeset Release Preview - v2.27.0 philipjonsen/chainlink#2

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Channel Definition Opts to LLO capability_trigger report type to enable Stream Multiplication #18463

Add Channel Definition Opts to LLO capability_trigger report type to enable Stream Multiplication #18463

cawthorne commented Jul 3, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 3, 2025

Uh oh!

fmunshi left a comment

Uh oh!

Uh oh!

bolekk left a comment

Uh oh!

bolekk Jul 4, 2025

Uh oh!

cawthorne Jul 4, 2025

Uh oh!

Uh oh!

cawthorne commented Jul 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Add Channel Definition Opts to LLO capability_trigger report type to enable Stream Multiplication #18463

Add Channel Definition Opts to LLO capability_trigger report type to enable Stream Multiplication #18463

Conversation

cawthorne commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 3, 2025

Uh oh!

fmunshi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bolekk left a comment

Choose a reason for hiding this comment

Uh oh!

bolekk Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

cawthorne Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cawthorne commented Jul 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cawthorne commented Jul 3, 2025 •

edited

Loading