Make Opts optional in LLO capability_trigger channel definition #18564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cawthorne
force-pushed
the
feature/allow-no-opts-in-capability-trigger-channel-definition
branch
from
e6bc4d8 to
4fe3b6a
Compare
cawthorne
changed the title
cawthorne
changed the title
|
brunotm
approved these changes
Jul 11, 2025
cedric-cordenier
approved these changes
Jul 11, 2025
secure-michelemin
deleted the
feature/allow-no-opts-in-capability-trigger-channel-definition
branch
cawthorne
added a commit
that referenced
this pull request
Jul 14, 2025
* Allow no opts in capability_trigger channel definition * fixup test * Make Opts optional for capability_trigger * Add changeset * Add changeset
cawthorne
added a commit
that referenced
this pull request
Jul 14, 2025
* Allow no opts in capability_trigger channel definition * fixup test * Make Opts optional for capability_trigger * Add changeset * Add changeset
cawthorne
added a commit
that referenced
this pull request
Jul 14, 2025
* Allow no opts in capability_trigger channel definition * fixup test * Make Opts optional for capability_trigger * Add changeset * Add changeset
cawthorne
added a commit
that referenced
this pull request
Jul 14, 2025
* Allow no opts in capability_trigger channel definition * fixup test * Make Opts optional for capability_trigger * Add changeset * Add changeset
HashWrangler
pushed a commit
that referenced
this pull request
Jul 14, 2025
* Allow no opts in capability_trigger channel definition * fixup test * Make Opts optional for capability_trigger * Add changeset * Add changeset
This was referenced Jun 4, 2025
cawthorne
added a commit
that referenced
this pull request
Jul 23, 2025
* Allow no opts in capability_trigger channel definition * fixup test * Make Opts optional for capability_trigger * Add changeset * Add changeset
cawthorne
added a commit
that referenced
this pull request
Jul 28, 2025
* Allow no opts in capability_trigger channel definition * fixup test * Make Opts optional for capability_trigger * Add changeset * Add changeset (cherry picked from commit 31711ce) Signed-off-by: Gregory Cawthorne <gregory.cawthorne@smartcontract.com>
cawthorne
added a commit
that referenced
this pull request
Jul 31, 2025
* Allow no opts in capability_trigger channel definition * fixup test * Make Opts optional for capability_trigger * Add changeset * Add changeset
cawthorne
added a commit
that referenced
this pull request
Aug 1, 2025
* Allow no opts in capability_trigger channel definition * fixup test * Make Opts optional for capability_trigger * Add changeset * Add changeset
cawthorne
added a commit
that referenced
this pull request
Aug 1, 2025
* Allow no opts in capability_trigger channel definition * fixup test * Make Opts optional for capability_trigger * Add changeset * Add changeset
cawthorne
added a commit
that referenced
this pull request
Aug 1, 2025
* Allow no opts in capability_trigger channel definition * fixup test * Make Opts optional for capability_trigger * Add changeset * Add changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The opts field for the LLO
capability_triggerchannel report type should be optional.