Skip to content

core/services/feeds: duplicate metrics w/o feeds_ prefix #18613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmank88 merged 1 commit into from
Jul 14, 2025
Merged

core/services/feeds: duplicate metrics w/o feeds_ prefix #18613

jmank88 merged 1 commit into from
Jul 14, 2025

Conversation

@jmank88
Copy link
Contributor

@jmank88 jmank88 commented Jul 14, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2025

I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@jmank88 jmank88 marked this pull request as ready for review July 14, 2025 20:21
@jmank88 jmank88 requested review from a team as code owners July 14, 2025 20:21
@jmank88 jmank88 requested a review from DylanTinianov July 14, 2025 20:21
@jmank88 jmank88 force-pushed the CRE-565-feeds-metrics branch from 5920dd4 to b6c8b23 Compare July 14, 2025 20:42
@jmank88
Copy link
Contributor Author

jmank88 commented Jul 14, 2025

Rebased to get past CI

@jmank88 jmank88 enabled auto-merge July 14, 2025 20:42
@jmank88 jmank88 added this pull request to the merge queue Jul 14, 2025
@cl-sonarqube-production
Copy link

cl-sonarqube-production bot commented Jul 14, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Merged via the queue into develop with commit 0acb254 Jul 14, 2025
152 of 153 checks passed
@jmank88 jmank88 deleted the CRE-565-feeds-metrics branch July 14, 2025 21:16
This was referenced Jul 14, 2025
Draft
Draft
Draft
@github-actions github-actions bot mentioned this pull request Jul 25, 2025
Merged
@github-actions github-actions bot mentioned this pull request Aug 21, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DylanTinianov DylanTinianov DylanTinianov approved these changes

@ChrisAmora ChrisAmora ChrisAmora approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmank88 @DylanTinianov @ChrisAmora