Add workflow key to standardcapabilities keystore #18917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vreff
changed the title
cedric-cordenier
previously approved these changes
Aug 26, 2025
pavel-raykov
previously approved these changes
Aug 26, 2025
| workflowKeys, err := node.KeyStore.Workflow().GetAll() | ||
| require.NoError(t, err) | ||
|
|
||
| // Workflow nodes should ony have at most 1 workflow key. |
| keystore, err = core.NewSingleAccountSigner(&core.P2PAccountKey, key) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to create single account signer for P2P key: %w", err) | ||
| if len(workflowKeys) > 0 { |
Collaborator
There was a problem hiding this comment.
Should we log a warning if the number of keys is more than 1?
Contributor
Author
There was a problem hiding this comment.
This is handled by the keystore itself: https://github.com/smartcontractkit/chainlink/blob/PRIV-126-workflow-key/core/services/keystore/workflow.go#L67
vreff
dismissed stale reviews from pavel-raykov and cedric-cordenier
via
e7001bb
pavel-raykov
approved these changes
Aug 26, 2025
jmank88
approved these changes
Aug 26, 2025
|
This was referenced Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
workflowKeyto its Keystore, if it is present.GetWorkflowPublicKeys(used in downstream tests).JIRA