Skip to content

Conversation

@pkcll
Copy link
Collaborator

@pkcll pkcll commented Aug 13, 2025

What

Add ChipIngressInsecureConnection config option
Bump chainlink-common for smartcontractkit/chainlink-common#1495

Why

ChipIngress should use TLS by default, while Beholder/OTel does not use TLS for local connection to sidecar collector by default.

@pkcll pkcll added build-publish Build and Publish image to SDLC and removed build-publish Build and Publish image to SDLC labels Aug 14, 2025
@pkcll pkcll force-pushed the INFOPLAT-2627-chip-ingress-client branch 3 times, most recently from b4040c3 to 0bf041a Compare August 14, 2025 14:03
@pkcll pkcll added the build-publish Build and Publish image to SDLC label Aug 15, 2025
@pkcll pkcll force-pushed the INFOPLAT-2627-chip-ingress-client branch from f9911e2 to cb95c1c Compare August 19, 2025 00:36
@pkcll pkcll force-pushed the INFOPLAT-2627-chip-ingress-client branch from cb95c1c to edba26e Compare August 19, 2025 03:49
@pkcll pkcll changed the title beholder: bump common Add ChipIngressInsecureConnection, ChipIngressForceIPV4 config options Aug 19, 2025
@pkcll pkcll requested a review from krehermann August 20, 2025 22:11
@pkcll pkcll changed the title Add ChipIngressInsecureConnection, ChipIngressForceIPV4 config options Wire up ChipIngressInsecureConnection config options Aug 21, 2025
@pkcll pkcll changed the title Wire up ChipIngressInsecureConnection config options Wire up ChipIngressInsecureConnection config option Aug 21, 2025
@pkcll pkcll marked this pull request as ready for review August 21, 2025 01:12
@pkcll pkcll requested review from a team as code owners August 21, 2025 01:12
go get github.com/smartcontractkit/chainlink-common/pkg/chipingress@v0.0.1
go get github.com/smartcontractkit/chainlink-common@INFOPLAT-2627-chip-ingress-config-insecure-connection
krehermann
krehermann previously approved these changes Aug 21, 2025
Tofel
Tofel previously approved these changes Aug 21, 2025
Copy link
Contributor

@Tofel Tofel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved core/scripts/cre && system-tests/ parts

patrickhuie19
patrickhuie19 previously approved these changes Aug 21, 2025
jmank88
jmank88 previously approved these changes Aug 21, 2025
@jmank88 jmank88 added this pull request to the merge queue Aug 21, 2025
krehermann
krehermann previously approved these changes Aug 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Aug 21, 2025
@pkcll pkcll dismissed stale reviews from krehermann, jmank88, and patrickhuie19 via 4718ee9 August 22, 2025 01:06
@cl-sonarqube-production
Copy link

@krehermann krehermann added this pull request to the merge queue Aug 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 22, 2025
@patrickhuie19 patrickhuie19 added this pull request to the merge queue Aug 22, 2025
Merged via the queue into develop with commit 145b6ee Aug 22, 2025
168 of 170 checks passed
@patrickhuie19 patrickhuie19 deleted the INFOPLAT-2627-chip-ingress-client branch August 22, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build-publish Build and Publish image to SDLC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants