DF-21546 Update deployment validation for data id #18972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cll-gg
changed the title
mxiao-cll
previously approved these changes
Aug 25, 2025
| attributeBucket := [2]byte{bytes[5], bytes[6]} | ||
| attributeBucketHex := hex.EncodeToString(attributeBucket[:]) | ||
| if attributeBucketHex != "0003" && attributeBucketHex != "0700" { | ||
| if attributeBucketHex != "0003" && attributeBucketHex != "0700" && attributeBucketHex != "0201" { |
There was a problem hiding this comment.
Can we add a comment on what these number are
karen-stepanyan
approved these changes
Aug 25, 2025
|
mxiao-cll
approved these changes
Aug 25, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
cll-gg
deleted the
DF-21546-update-df-setfeedconfigchangeset-secure-mint
branch
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 16, 2025
* Revert "DF-21815 Use seqNr as timestamp in secure mint report (#19152)" This reverts commit b464a4a. * Revert "DF-21546 Allow configuring secure mint data id in workflow (#19106)" This reverts commit db51db1. * Revert "DF-21518 Use latest sm aggregator without seq nr issue (#18926)" This reverts commit 28fcb5c. * Revert "DF-21518 Use correct data id in SM aggregator (#18870)" This reverts commit dc659a0. * Revert "DF-21518 Use the secure mint aggregator in the consensus capability (#18841)" This reverts commit 7311de5. * Lagging merge conflict resolutions * Keep secure mint in aggregator factory to let solana secure_mint test run * see #19091 * Run make tidy * Fix duplicate import * Run make tidy once more * Add changeset * Revert "DF-21546 Update deployment validation for data id (#18972)" This reverts commit dedf6ae.
cll-gg
added a commit
that referenced
this pull request
Sep 16, 2025
* Revert "DF-21815 Use seqNr as timestamp in secure mint report (#19152)" This reverts commit b464a4a. * Revert "DF-21546 Allow configuring secure mint data id in workflow (#19106)" This reverts commit db51db1. * Revert "DF-21518 Use latest sm aggregator without seq nr issue (#18926)" This reverts commit 28fcb5c. * Revert "DF-21518 Use correct data id in SM aggregator (#18870)" This reverts commit dc659a0. * Revert "DF-21518 Use the secure mint aggregator in the consensus capability (#18841)" This reverts commit 7311de5. * Lagging merge conflict resolutions * Keep secure mint in aggregator factory to let solana secure_mint test run * see #19091 * Run make tidy * Fix duplicate import * Run make tidy once more * Add changeset * Revert "DF-21546 Update deployment validation for data id (#18972)" This reverts commit dedf6ae.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve data id validation