[PRODCRE-792] Support capabilities that are both Triggers and Executables #19102
Conversation
bolekk
force-pushed
the
feature/PRODCRE-792-remote-shims-for-v2-caps
branch
2 times, most recently
from
bb70143 to
aaa59f7
Compare
bolekk
force-pushed
the
feature/PRODCRE-792-remote-shims-for-v2-caps
branch
6 times, most recently
from
89c0710 to
ca7a685
Compare
bolekk
force-pushed
the
feature/PRODCRE-792-remote-shims-for-v2-caps
branch
3 times, most recently
from
cc59a85 to
b5609e0
Compare
bolekk
changed the title
core/capabilities/launcher.go
Outdated
|
|
||
| methodConfig := capabilityConfig.CapabilityMethodConfig | ||
| if methodConfig != nil { // v2 capability | ||
| w.exposeCapabilityV2(ctx, cid, methodConfig, myPeerID, don, idsToDONs) |
There was a problem hiding this comment.
also, shouldn't you check capability.CapabilityType==nil to make sure people not use both types of parametrizations at the same time?
There was a problem hiding this comment.
This type doesn't matter here any more. exposeCapabilityV2() goes method-by-method
| return nil | ||
| } | ||
|
|
||
| func (w *launcher) exposeCapabilityV2(ctx context.Context, capID string, methodConfig map[string]capabilities.CapabilityMethodConfig, myPeerID p2ptypes.PeerID, myDON registrysyncer.DON, idsToDONs map[uint32]capabilities.DON) error { |
There was a problem hiding this comment.
@george-dorin uncovered a very hairy bug (ticket pending...) where it seem like if the loop crashes the in-memory registry is corrupted and never recovers despite a new loop process starting.
how does this code get alerted/triggered by, say, a looop restart?
There was a problem hiding this comment.
It doesn't. And it didn't even before this change :( I opened a separate epic to handle dynamic updates to underlying capabilities and config, which should include LOOPP restarts (CRE-788)
bolekk
force-pushed
the
feature/PRODCRE-792-remote-shims-for-v2-caps
branch
7 times, most recently
from
30d2f55 to
a6bea65
Compare
bolekk
force-pushed
the
feature/PRODCRE-792-remote-shims-for-v2-caps
branch
from
a6bea65 to
7c7cebc
Compare
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…bles (#19102) [DRAFT][PRODCRE-792] Support capabilities that are both Triggers and Executables
5 participants
Launcher per-method shims and CombinedClient.
CombinedClient unit tests generated with Claude.