[CRE-764] System tests refactoring #19130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chudilka1
force-pushed
the
CRE-764-system-tests-refactoring
branch
10 times, most recently
from
88c1487 to
8df931f
Compare
chudilka1
changed the title
chudilka1
force-pushed
the
CRE-764-system-tests-refactoring
branch
2 times, most recently
from
42879f9 to
975192a
Compare
Tofel
reviewed
Aug 28, 2025
core/scripts/cre/environment/examples/workflows/v2/http_simple/main.go
Outdated
Show resolved
Hide resolved
Tofel
reviewed
Aug 28, 2025
chudilka1
force-pushed
the
CRE-764-system-tests-refactoring
branch
7 times, most recently
from
d111e54 to
c14dd06
Compare
chudilka1
requested review from
krehermann
and removed request for
patrickhuie19
chudilka1
force-pushed
the
CRE-764-system-tests-refactoring
branch
5 times, most recently
from
e64bc6f to
39434e1
Compare
Refactoring: move re-used common utility methods in the tests to smoke-tests/cmd package Refactoring: move re-used logically grouped steps to helpers_test.go Refactoring: externalize CREv1 PoR smoke-test to a separate file. Refactoring: externalize CREv1 PoR smoke-test to a separate file. Refactoring: externalize CREv2 smoke-tests to separate files. Refactoring: update system-test files names and README.
chudilka1
force-pushed
the
CRE-764-system-tests-refactoring
branch
4 times, most recently
from
e2613e6 to
07b8004
Compare
Tofel
reviewed
Aug 29, 2025
chudilka1
force-pushed
the
CRE-764-system-tests-refactoring
branch
from
07b8004 to
ed3f677
Compare
chudilka1
force-pushed
the
CRE-764-system-tests-refactoring
branch
from
ed3f677 to
b51a15e
Compare
Tofel
approved these changes
Aug 29, 2025
|
george-dorin
approved these changes
Aug 29, 2025
This was referenced Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRE-764: CRE v1/v2 system tests refactoring
before_suite.go.helpers_test.go.system-tests/libto preserve the Single Responsibility Principle.