Add DKGRecipient P256 key #19161
Add DKGRecipient P256 key #19161
Conversation
vreff
force-pushed
the
PRIV-150-DKG-database
branch
from
bd37cf2 to
c0e9ebc
Compare
… into PRIV-149-p256-key
product-security-plaid-test
bot
requested review from
Tofel and
cedric-cordenier
| } | ||
|
|
||
| // EnsureKey verifies whether the DKGRecipient key has been seeded, if not, it creates it. | ||
| func (ks *dkgRecipient) EnsureKey(ctx context.Context) error { |
There was a problem hiding this comment.
@vreff Not sure if you were planning on doing this in a later PR, but we should call this in application.go (wherever we call the code for the workflowkey); all nodes should automatically get a key of this type
There was a problem hiding this comment.
Yeah, have it as a planned change here: #19160
There was a problem hiding this comment.
I am adding a configuration field DKGRecipientEnabled that gates the creation of the key, though. Is this falling out of fashion, and we would rather just create the key for all nodes no matter what these days? Happy to do either.
There was a problem hiding this comment.
I would think we do need to gate the creation.
Not all nodes will be vault DON nodes right @cedric-cordenier ?
prashantkumar1982
dismissed stale reviews from cedric-cordenier and themself
The base branch was changed.
|
* Add dkgresult database * add p256 key to keystore * tests * Add dkgresult database * make gomodtidy * make generate * fix lint / possible overflow error * fix lint * update test package * Update to use new keyring * make gomodtidy * make gomodtidy * make generate * remove ensurekey * add more tests * fix lint * changeset * gomodtidy
3 participants
This PR adds a DKGRecipient P256 key to the keystore.
Related:
#19162
#19160
smartcontractkit/chainlink-common#1508