Skip to content

Skip capability_trigger reports in Mercury Server #19215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cawthorne merged 3 commits into from
Sep 4, 2025
Merged

Skip capability_trigger reports in Mercury Server #19215

cawthorne merged 3 commits into from
Sep 4, 2025

Conversation

@cawthorne
Copy link
Contributor

@cawthorne cawthorne commented Sep 3, 2025

No description provided.

@cawthorne cawthorne requested review from a team as code owners September 3, 2025 22:30
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

ro-tex
ro-tex reviewed Sep 4, 2025
View reviewed changes
@cawthorne @ro-tex
Update core/services/llo/mercurytransmitter/server.go
2c4b0d6 
Co-authored-by: Ivaylo Novakov <ivaylo.novakov@smartcontract.com>
@cawthorne cawthorne requested a review from ro-tex September 4, 2025 09:25
@cawthorne cawthorne added build-publish Build and Publish image to SDLC and removed build-publish Build and Publish image to SDLC labels Sep 4, 2025
ro-tex
ro-tex approved these changes Sep 4, 2025
View reviewed changes
Copy link
Contributor

@ro-tex ro-tex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cl-sonarqube-production
Copy link

cl-sonarqube-production bot commented Sep 4, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@cawthorne cawthorne enabled auto-merge September 4, 2025 13:23
@cawthorne cawthorne disabled auto-merge September 4, 2025 18:03
@cawthorne cawthorne enabled auto-merge September 4, 2025 18:03
@cawthorne cawthorne added this pull request to the merge queue Sep 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 4, 2025
@cawthorne cawthorne added this pull request to the merge queue Sep 4, 2025
Merged via the queue into develop with commit 54941a5 Sep 4, 2025
173 of 180 checks passed
@cawthorne cawthorne deleted the feature/skip-capability-trigger-reports-in-mercury-server branch September 4, 2025 19:49
HashWrangler pushed a commit that referenced this pull request Sep 4, 2025
@cawthorne @ro-tex @HashWrangler
Skip capability_trigger reports in Mercury Server (#19215)
cf2c963 
* Skip capability_trigger reports in Mercury Server

* Remove log

* Update core/services/llo/mercurytransmitter/server.go

Co-authored-by: Ivaylo Novakov <ivaylo.novakov@smartcontract.com>

---------

Co-authored-by: Ivaylo Novakov <ivaylo.novakov@smartcontract.com>
@HashWrangler HashWrangler mentioned this pull request Sep 4, 2025
Closed
HashWrangler pushed a commit that referenced this pull request Sep 4, 2025
@cawthorne @ro-tex @HashWrangler
Skip capability_trigger reports in Mercury Server (#19215)
12dbbd2 
* Skip capability_trigger reports in Mercury Server

* Remove log

* Update core/services/llo/mercurytransmitter/server.go

Co-authored-by: Ivaylo Novakov <ivaylo.novakov@smartcontract.com>

---------

Co-authored-by: Ivaylo Novakov <ivaylo.novakov@smartcontract.com>
This was referenced Sep 4, 2025
Closed
Closed
ro-tex added a commit that referenced this pull request Sep 5, 2025
@cawthorne @ro-tex
Skip capability_trigger reports in Mercury Server (#19215)
08f1923 
* Skip capability_trigger reports in Mercury Server

* Remove log

* Update core/services/llo/mercurytransmitter/server.go

Co-authored-by: Ivaylo Novakov <ivaylo.novakov@smartcontract.com>

---------

Co-authored-by: Ivaylo Novakov <ivaylo.novakov@smartcontract.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ro-tex ro-tex ro-tex approved these changes

@krehermann krehermann krehermann approved these changes

@FelixFan1992 FelixFan1992 FelixFan1992 approved these changes

@akuzni2 akuzni2 Awaiting requested review from akuzni2

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cawthorne @ro-tex @krehermann @FelixFan1992