PRIV-152: Run DKG in local CRE.#19301
Conversation
core/services/ocr2/delegate.go
Outdated
| ) (srvs []job.ServiceCtx, err error) { | ||
| spec := jb.OCR2OracleSpec | ||
|
|
||
| dkgRecipientKeys, err := d.dkgRecipientKs.GetAll() |
There was a problem hiding this comment.
There should be a helper you can use to get this key btw, see https://github.com/smartcontractkit/chainlink/pull/19301/files#diff-ee42cd8d3c2284e2aa914b4f7797b308ef4bf9f3e73a5692da84685f3bf9f542R808
| return DeployDKGOutput{}, fmt.Errorf("failed to merge datastore: %w", err) | ||
| } | ||
|
|
||
| if err := ds.AddressRefStore.Add(addressRef); err != nil { |
There was a problem hiding this comment.
I think the AddressBook is supposed to be part of the legacy API 🤔 I'm not sure if new changesets need to support it though; let me start a thread with Keith and ask him
There was a problem hiding this comment.
Cool thanks. All this code was completely new to me so I navigated it as best I could.
product-security-plaid-test
bot
requested review from
CL-Eric,
DimitriosNaikopoulos,
ajaskolski,
bolekk,
bytesizedroll,
giogam,
graham-chainlink,
jkongie and
securejavier
| break | ||
| } | ||
| } | ||
| if vaultFound { |
There was a problem hiding this comment.
Should we also ensure vault capability is only in 1 of the NodeSets?
There was a problem hiding this comment.
Could you move this code to this place:
system-tests/lib/cre/capabilities/vault/vault.go
This way all of vault setup code is in the same place.
Also, can you check the existing vault code around keys there? Perhaps some of that is obsolete after your changes.
* Run Vault DON E2E tests using the DKG * fix lint errors * add backoff * Fix race * fix test * changeset
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
3 participants
This PR: