chore: merge release/2.28.0 back into develop (post-GA hygiene) #19326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-security-plaid-test
bot
requested review from
gustavogama-cll and
vyzaldysanchez
Contributor
|
👋 HashWrangler, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
gustavogama-cll
previously approved these changes
Sep 10, 2025
vyzaldysanchez
previously approved these changes
Sep 10, 2025
HashWrangler
dismissed stale reviews from vyzaldysanchez and gustavogama-cll
via
781b742
archseer
previously approved these changes
Sep 10, 2025
…e changeset (#internal) Signed-off-by: HashWrangler <jd@smartcontract.com>
Signed-off-by: HashWrangler <jd@smartcontract.com>
HashWrangler
force-pushed
the
chore/merge-release-2.28.0-into-develop
branch
from
7647f27 to
fe12ddd
Compare
erikburt
reviewed
Sep 10, 2025
- Update deployment/go.mod to use v2.27.3-0.20250908153844-03478edcd69f (from develop) - Update core/scripts/go.mod to use v2.27.3-0.20250908153844-03478edcd69f (from develop) - Update deployment version in core/scripts to v0.0.0-20250906212935-a1521d24f47f This ensures we keep the newer versions from develop rather than downgrading to older versions from release/2.28.0 during the hygiene merge.
- Update integration-tests/go.mod to use v2.27.3-0.20250908153844-03478edcd69f - Update integration-tests/load/go.mod to use v2.27.3-0.20250908153844-03478edcd69f - Update system-tests/lib/go.mod to use v2.27.3-0.20250908153844-03478edcd69f - Update system-tests/tests/go.mod to use v2.27.3-0.20250908153844-03478edcd69f This ensures all submodules use the correct newer version from develop instead of the older version from release/2.28.0, which should resolve CI failures related to version inconsistencies.
erikburt
reviewed
Sep 10, 2025
core/scripts/go.mod
Outdated
| github.com/smartcontractkit/chainlink/core/scripts/cre/environment/examples/workflows/v1/proof-of-reserve/cron-based v0.0.0-20250826151008-ae5ec0ee6f2c | ||
| github.com/smartcontractkit/chainlink/core/scripts/cre/environment/examples/workflows/v1/proof-of-reserve/web-trigger-based v0.0.0-20250826151008-ae5ec0ee6f2c | ||
| github.com/smartcontractkit/chainlink/system-tests/lib v0.0.0-20250908212658-66264730d63f | ||
| github.com/smartcontractkit/chainlink/system-tests/lib v0.0.0-20250826151008-ae5ec0ee6f2c |
Collaborator
There was a problem hiding this comment.
This seems to be downgrading the dep's version here as well.
- Newer: 66264730d63f
- Older: ae5ec0ee6f2c
system-tests/lib/go.mod
Outdated
| github.com/smartcontractkit/chainlink-testing-framework/lib v1.54.4 | ||
| github.com/smartcontractkit/chainlink-testing-framework/seth v1.51.2 | ||
| github.com/smartcontractkit/chainlink/deployment v0.0.0-20250906212935-a1521d24f47f | ||
| github.com/smartcontractkit/chainlink/deployment v0.0.0-20250826151008-ae5ec0ee6f2c |
…upgrade This commit fixes critical version downgrades that were introduced during the merge: CRITICAL FIXES: - Restored all go.mod files from develop to prevent version downgrades - Applied only the chain-selectors upgrade (v1.0.67 → v1.0.70) from release/2.28.0 - Prevented Kubernetes package downgrades (k8s.io/api, apimachinery, client-go) - Prevented other package downgrades (rs/xid, sigs.k8s.io packages) VERSION CONSISTENCY: - All chainlink/v2 references: v2.27.3-0.20250908153844-03478edcd69f (from develop) - All chain-selectors references: v1.0.70 (from release/2.28.0) - All go.sum files updated via 'go mod tidy' for consistency This ensures the PR is strictly hygiene-only with no functional regressions. All modules verified and consistent across submodules.
erikburt
approved these changes
Sep 10, 2025
jmank88
reviewed
Sep 10, 2025
Contributor
There was a problem hiding this comment.
Do we need to count this as a change?
jmank88
approved these changes
Sep 10, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the release/2.28.0 branch back into develop to keep version history aligned and unblock Go module resolution. No new features, just hygiene after GA.