[CRE-788] Support dynamic config updates in TriggerSubscriber #19404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolekk
force-pushed
the
feature/CRE-788-remote-shims-dynamic-updates
branch
11 times, most recently
from
919e5bc to
be2b605
Compare
bolekk
changed the title
bolekk
force-pushed
the
feature/CRE-788-remote-shims-dynamic-updates
branch
4 times, most recently
from
6043b2b to
facf0c6
Compare
product-security-plaid-test
bot
requested review from
DylanTinianov,
jmank88 and
silaslenihan
ettec
reviewed
Sep 25, 2025
bolekk
force-pushed
the
feature/CRE-788-remote-shims-dynamic-updates
branch
from
facf0c6 to
21a7b3d
Compare
bolekk
force-pushed
the
feature/CRE-788-remote-shims-dynamic-updates
branch
from
21a7b3d to
786f0fb
Compare
|
mchain0
approved these changes
Sep 26, 2025
ettec
approved these changes
Sep 26, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launcher is currently unable to update shims for remote capabilities. Once a shim is created and connected to underlying services (registry, dispatcher) it can't be replaced with a new one. This PR fixes that by introducing dynamic config updates for existing shims.
To be followed up with another PR that migrates other shims to similar SetConfig() calls (i.e. TriggerPublisher, ExecutableClient and ExecutableServer)