fix(workflows/syncer/v2): addresses nil checks and startup #19519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-security-plaid-test
bot
requested review from
jmank88 and
krehermann
Contributor
|
👋 MStreet3, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
MStreet3
commented
Sep 24, 2025
| } | ||
|
|
||
| w.contractReader = reader | ||
| close(initDoneCh) |
Contributor
Author
There was a problem hiding this comment.
only close initDoneCh if the reader is initialized, otherwise the context is canceled and the waiting routines will stop.
MStreet3
commented
Sep 24, 2025
| } | ||
| w.lggr.Debugw("read from don received channel while waiting to start reconciliation sync") | ||
| don, _ := w.workflowDonNotifier.WaitForDon(ctx) | ||
| don, err := w.workflowDonNotifier.WaitForDon(ctx) |
Contributor
Author
There was a problem hiding this comment.
should never happen, but handling error now by passing it to client provided hook with default noop implementation
|
mchain0
approved these changes
Sep 24, 2025
george-dorin
approved these changes
Sep 24, 2025
jmank88
approved these changes
Sep 24, 2025
This was referenced Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR :
nilcontractReaderwhen starting sync after a successful close ofinitDoneChyeterrorwaiting for DONeventChin V2HealthReportRequires
Supports