Add workflow registry chain selector to v2 events #19667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeividasK
commented
Oct 1, 2025
| return &eventsv2.TransactionInfo{ | ||
| ChainSelector: "", // TODO CRE-887 add chain selector to tx info | ||
| TxHash: hex.EncodeToString(head.Hash), | ||
| GasCost: "", // TODO CRE-886 add gas cost to tx info |
Contributor
Author
There was a problem hiding this comment.
Removing this TODO as it is a "won't do"
DeividasK
force-pushed
the
CRE-887-add-chain-selector-to-tx-info-struct-in-v-2-deployment-events
branch
from
95041d3 to
3782738
Compare
…stryChainSelector
…selector-to-tx-info-struct-in-v-2-deployment-events
…selector-to-tx-info-struct-in-v-2-deployment-events
jmank88
approved these changes
Oct 2, 2025
| key, | ||
| syncerV2.WithBillingClient(billingClient), | ||
| syncerV2.WithWorkflowRegistry(capCfg.WorkflowRegistry().Address(), capCfg.WorkflowRegistry().ChainID()), | ||
| syncerV2.WithWorkflowRegistry(capCfg.WorkflowRegistry().Address(), strconv.FormatUint(wrChainDetails.ChainSelector, 10)), |
Contributor
There was a problem hiding this comment.
if this expected chain ID previously, is there downstream logic that needs to be removed that converted the chain ID to a chain selector?
Contributor
Author
There was a problem hiding this comment.
I'm not sure if the consumers were just ignoring this value or if they actually did the conversion to the selector.
jmank88
previously approved these changes
Oct 2, 2025
patrickhuie19
approved these changes
Oct 2, 2025
jmank88
approved these changes
Oct 2, 2025
|
auto-merge was automatically disabled
October 2, 2025 21:49
Pull Request is not mergeable
patrickhuie19
deleted the
CRE-887-add-chain-selector-to-tx-info-struct-in-v-2-deployment-events
branch
This was referenced Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.