core/cmd: restore background context to avoid race #19906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
commented
Oct 15, 2025
Comment on lines
333
to
334
| shutdownStartTime = time.Now() | ||
| cancelRootCtx() |
Contributor
Author
There was a problem hiding this comment.
This must be the only cancellation of rootCtx.
kirqz23
approved these changes
Oct 15, 2025
pavel-raykov
approved these changes
Oct 15, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #19089
Wiring the CLI context directly through takes away the happens-before guarantee from cancelling in the shutdown goroutine after setting the
shutdownStartTime, leading to a data race.