-
Notifications
You must be signed in to change notification settings - Fork 1.9k
INFOPLAT-3111: Fix atomic swapper for otel zap core #20019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 kirqz23, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|




The
AtomicCore.With()method was breaking the atomic chain when fields were applied to the logger, preventing swapping of otel core correctly. The main issue was thatd.load().With(fs)was returning totally new noop core disconnected from atomic core.The fix introduces a weak pointer solution that maintains atomic core connections while preventing memory leaks and tracks child cores created via
.With()calls.