fix(capabilities): writes warn log correctly #20077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-security-plaid-production
bot
requested review from
jmank88 and
nolag
Contributor
|
👋 MStreet3, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
MStreet3
commented
Oct 27, 2025
|
|
||
| if len(c.responseIDCount) > 1 { | ||
| lggr.Warn("received multiple different responses for the same request, number of different responses received: %d", len(c.responseIDCount)) | ||
| lggr.Warnw("received multiple unique responses for the same request", "count for responseID", len(c.responseIDCount)) |
Contributor
Author
There was a problem hiding this comment.
log already has responseID via With
krehermann
reviewed
Oct 27, 2025
| } | ||
|
|
||
| // TransmissionConfig has to be set only for V2 capabilities. V1 capabilities read transmission schedule from every request. | ||
| func NewClientExecuteRequest(ctx context.Context, lggr logger.Logger, req commoncap.CapabilityRequest, |
Contributor
There was a problem hiding this comment.
why?
,
)
seem must less legible than )
Contributor
Author
There was a problem hiding this comment.
autocorrect by gofumpt
krehermann
approved these changes
Oct 27, 2025
|
patrickhuie19
approved these changes
Oct 27, 2025
justinkaseman
approved these changes
Oct 27, 2025
This was referenced Oct 27, 2025
MStreet3
added a commit
that referenced
this pull request
Oct 30, 2025
* fix(capabilities): writes warn log correctly * deps: changeset
This was referenced Nov 7, 2025
This was referenced Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Supports