[DS-1142] Support multiple channel definition sources#20305
Merged
Conversation
brunotm
force-pushed
the
DS-1142-llo-channeldef-reconcile
branch
3 times, most recently
from
68161e6 to
0e13507
Compare
brunotm
force-pushed
the
DS-1142-llo-channeldef-reconcile
branch
7 times, most recently
from
15f6e30 to
2370529
Compare
akuzni2
reviewed
Nov 17, 2025
core/services/llo/channeldefinitions/onchain_channel_definition_cache.go
Show resolved
Hide resolved
akuzni2
reviewed
Nov 17, 2025
core/services/llo/channeldefinitions/onchain_channel_definition_cache.go
Show resolved
Hide resolved
akuzni2
reviewed
Nov 17, 2025
core/services/llo/channeldefinitions/onchain_channel_definition_cache.go
Outdated
Show resolved
Hide resolved
akuzni2
reviewed
Nov 18, 2025
core/services/llo/channeldefinitions/onchain_channel_definition_cache.go
Show resolved
Hide resolved
ro-tex
reviewed
Nov 18, 2025
core/services/llo/channeldefinitions/onchain_channel_definition_cache.go
Outdated
Show resolved
Hide resolved
core/services/llo/channeldefinitions/onchain_channel_definition_cache.go
Show resolved
Hide resolved
Contributor
|
The changes look good to me so far. Alex brings up some good points for simplifying the code - if those are viable that might be a nice improvement. |
brunotm
force-pushed
the
DS-1142-llo-channeldef-reconcile
branch
from
2370529 to
bfef37c
Compare
mvidigueira
reviewed
Nov 19, 2025
core/services/llo/channeldefinitions/onchain_channel_definition_cache.go
Outdated
Show resolved
Hide resolved
brunotm
force-pushed
the
DS-1142-llo-channeldef-reconcile
branch
from
ded5ca0 to
a6318ba
Compare
mvidigueira
reviewed
Nov 20, 2025
core/services/llo/channeldefinitions/onchain_channel_definition_cache.go
Outdated
Show resolved
Hide resolved
mvidigueira
reviewed
Nov 20, 2025
core/services/llo/channeldefinitions/onchain_channel_definition_cache.go
Outdated
Show resolved
Hide resolved
mvidigueira
reviewed
Nov 20, 2025
core/services/llo/channeldefinitions/onchain_channel_definition_cache.go
Outdated
Show resolved
Hide resolved
mvidigueira
reviewed
Nov 20, 2025
core/services/llo/channeldefinitions/onchain_channel_definition_cache.go
Outdated
Show resolved
Hide resolved
mvidigueira
reviewed
Nov 20, 2025
core/services/llo/channeldefinitions/onchain_channel_definition_cache.go
Show resolved
Hide resolved
brunotm
force-pushed
the
DS-1142-llo-channeldef-reconcile
branch
5 times, most recently
from
55395ec to
24d7247
Compare
ro-tex
previously approved these changes
Dec 11, 2025
mvidigueira
reviewed
Dec 11, 2025
mvidigueira
reviewed
Dec 11, 2025
core/services/llo/channeldefinitions/onchain_channel_definition_cache.go
Outdated
Show resolved
Hide resolved
mvidigueira
reviewed
Dec 11, 2025
core/services/llo/channeldefinitions/onchain_channel_definition_cache.go
Outdated
Show resolved
Hide resolved
mvidigueira
reviewed
Dec 11, 2025
core/services/llo/channeldefinitions/onchain_channel_definition_cache.go
Show resolved
Hide resolved
mvidigueira
reviewed
Dec 11, 2025
core/services/llo/channeldefinitions/onchain_channel_definition_cache.go
Outdated
Show resolved
Hide resolved
mvidigueira
reviewed
Dec 11, 2025
core/services/llo/channeldefinitions/onchain_channel_definition_cache.go
Outdated
Show resolved
Hide resolved
mvidigueira
reviewed
Dec 11, 2025
core/services/llo/channeldefinitions/onchain_channel_definition_cache.go
Outdated
Show resolved
Hide resolved
…efaultFetchTimeout and fetchRetryTimeout
brunotm
force-pushed
the
DS-1142-llo-channeldef-reconcile
branch
from
09f58c6 to
fb9c227
Compare
ro-tex
approved these changes
Dec 12, 2025
|
JoshC2k
approved these changes
Dec 12, 2025
mvidigueira
approved these changes
Dec 12, 2025
kidambisrinivas
approved these changes
Dec 12, 2025
ettec
approved these changes
Dec 12, 2025
This was referenced Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for multiple unprivileged channel definition sources.
It reconciles new channel definitions with the current set according to source authority rules. Owner definitions (SourceOwner) have full authority: they can add, update, or tombstone (delete) channels. Adder definitions (non-owner sources) have limited authority: they can only add new channels and cannot overwrite or tombstone existing ones.