Tempo - add cs to change default fee token #20510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flodesi
changed the title
Contributor
CORA - Pending ReviewersAll codeowners have approved! ✅ Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
simsonraj
reviewed
Dec 3, 2025
simsonraj
reviewed
Dec 3, 2025
simsonraj
reviewed
Dec 3, 2025
| return out, fmt.Errorf("abi pack: %w", err) | ||
| } | ||
|
|
||
| data = append(data, encodedArgs...) |
Contributor
There was a problem hiding this comment.
very minor nit, I think there is a slightly better way to do this, using abi.pack or something like that. but this is fine as well
simsonraj
reviewed
Dec 3, 2025
simsonraj
reviewed
Dec 4, 2025
Comment on lines
32
to
37
| chain, err := findChainBySelector(env, cfg.ChainSel) | ||
| if err != nil { | ||
| return out, fmt.Errorf("error: %w finding chain by selector: %d", err, cfg.ChainSel) | ||
| } | ||
|
|
||
| evmChain, ok := chain.(evm.Chain) |
Contributor
There was a problem hiding this comment.
you can simply do, instead of findChainBySelector method & casting
env.BlockChains.EVMChains()[chainSelector]
simsonraj
approved these changes
Dec 4, 2025
|
flodesi
changed the title
flodesi
requested review from
0xAustinWang,
agusaldasoro,
chris-de-leon-cll and
tt-cll
product-security-plaid-production
bot
requested review from
Atrax1 and
ChrisAmora
joaoluisam
approved these changes
Dec 4, 2025
ChrisAmora
approved these changes
Dec 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.