Skip to content

Logging for failed GetSecrets in Workflows #20556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prashantkumar1982 merged 4 commits into from
Dec 8, 2025
Merged

Logging for failed GetSecrets in Workflows #20556

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce3a059
Logging for failed GetSecrets in Workflows
prashantkumar1982 Dec 8, 2025
d9d5ebb
nit
prashantkumar1982 Dec 8, 2025
cb26425
nit
prashantkumar1982 Dec 8, 2025
3477953
Merge branch 'develop' of https://github.com/smartcontractkit/chainli…
prashantkumar1982 Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions core/services/workflows/v2/secrets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,16 @@ func (s *secretsFetcher) GetSecrets(ctx context.Context, request *sdkpb.GetSecre
defer free()
return s.getSecretsForBatch(ctx, request)
}()

getSecretsDuration := time.Since(start).Milliseconds()
if err != nil {
// Log errors when secrets fetching fails, for troubleshooting and debugging
s.lggr.Warnw("Secrets fetching failed for request", "request", request, "error", err, "requestLatency", getSecretsDuration)
}
s.metrics.With(
"workflowOwner", s.workflowOwner,
"workflowName", s.workflowName,
"success", strconv.FormatBool(err == nil),
).RecordGetSecretsDuration(ctx, time.Since(start).Milliseconds())
).RecordGetSecretsDuration(ctx, getSecretsDuration)

return resp, err
}
Expand Down
Loading