Only load state once in proposal generation #20575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AnieeG
approved these changes
Dec 10, 2025
KodeyThomas
approved these changes
Dec 10, 2025
carte7000
requested review from
0xAustinWang,
AmrMohamedRezk,
agusaldasoro,
chris-de-leon-cll,
matYang,
tt-cll and
winder
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes proposal generation by eliminating redundant state loading operations. The ValidateMCMS function previously loaded on-chain state internally for each chain, which was inefficient when validating multiple chains. By refactoring it to accept state as a parameter (ValidateMCMSWithState), the state can now be loaded once and reused across all validation calls.
Key changes:
- Refactored
ValidateMCMSto accept state as a parameter, renaming it toValidateMCMSWithState - Removed internal state loading logic from the validation function
- Updated caller to pass pre-loaded state
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only load state once in proposal generation